From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4CBBB1FF16B for ; Tue, 15 Jul 2025 16:31:55 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E907D3FBCB; Tue, 15 Jul 2025 16:32:26 +0200 (CEST) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Tue, 15 Jul 2025 16:31:57 +0200 Message-Id: <20250715143218.1548306-14-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250715143218.1548306-1-a.lauterer@proxmox.com> References: <20250715143218.1548306-1-a.lauterer@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH widget-toolkit v3 2/2] rrdchart: use reference for undo button X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" This makes targeting the undo button more stable in situations where it might not be the 0 indexed item in the tools. Signed-off-by: Aaron Lauterer --- src/panel/RRDChart.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/panel/RRDChart.js b/src/panel/RRDChart.js index 3b41ae6..f9a9b33 100644 --- a/src/panel/RRDChart.js +++ b/src/panel/RRDChart.js @@ -152,7 +152,7 @@ Ext.define('Proxmox.widget.RRDChart', { return; } // if the undo button is disabled, disable our tool - let ourUndoZoomButton = chart.header.tools[0]; + let ourUndoZoomButton = chart.lookupReference('undoButton'); let undoButton = chart.interactions[0].getUndoButton(); ourUndoZoomButton.setDisabled(undoButton.isDisabled()); }, @@ -269,6 +269,7 @@ Ext.define('Proxmox.widget.RRDChart', { me.addTool({ type: 'minus', disabled: true, + reference: 'undoButton', tooltip: gettext('Undo Zoom'), handler: function () { let undoButton = me.interactions[0].getUndoButton(); -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel