From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 44F6F1FF183 for ; Wed, 2 Jul 2025 18:30:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 055D432978; Wed, 2 Jul 2025 18:29:01 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Wed, 2 Jul 2025 18:28:20 +0200 Message-ID: <20250702162838.393696-48-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250702162838.393696-1-f.ebner@proxmox.com> References: <20250702162838.393696-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server v3 47/51] live import/restore: use Blockdev::detach helper X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Which also catches scenarios where the block node is already gone, which can happen with -blockdev. Signed-off-by: Fiona Ebner --- src/PVE/QemuServer.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index d4154aeb..d9284843 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -7057,7 +7057,7 @@ sub pbs_live_restore { . " to disconnect from Proxmox Backup Server\n"; for my $ds (sort keys %$restored_disks) { - mon_cmd($vmid, 'blockdev-del', 'node-name' => "$ds-pbs"); + PVE::QemuServer::Blockdev::detach($vmid, "$ds-pbs"); } close($qmeventd_fd); @@ -7159,7 +7159,7 @@ sub live_import_from_files { print "restore-drive jobs finished successfully, removing all tracking block devices\n"; for my $ds (sort keys %$live_restore_backing) { - mon_cmd($vmid, 'blockdev-del', 'node-name' => "drive-$ds-restore"); + PVE::QemuServer::Blockdev::detach($vmid, "drive-$ds-restore"); } close($qmeventd_fd); -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel