From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9E49F1FF170 for ; Thu, 26 Jun 2025 04:44:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 691E61EB9F; Thu, 26 Jun 2025 04:45:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Mv/YIYElMJqPhO+4D9tspn17I+NQQNBhrriz6zBtxcHeUDvOwqHvRaes0OBEGOLQN5W/QNYY7uwuUe7U9pYWuRDIa65kC7vzz9mg8CizBDynnCHYz32H/P8Djob8ZWw15PEVCaFBjnRwITBLyEFAjjvfk+cJOh3gR18S5RXUXNk0vWYE+lXkwrlEsaZGtp/xmECBO9JZBk8QSZgRSzf6A6epojNosjFma2ks9uk5c45uMWxGSFd43bKxkpJRbseiQ725FW/ZF/9upY1y+mrXDwH7dv5p1OihKABiOwMWRkTetHdGUnvmQ4XKxclr7fRdMv3sClip76CK16P6QkrcwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2lUGt6AJKZshCj5ptobcophz3cQxU2HY2jKGxWhdAZQ=; b=opNwMRG4TieuTIt1ksleoJvjhyEkghSWoeFw1c8/SRjuHko36RwvwERBHiZUXNzrswfX1J2HXQa2vV1Pfk25M+4zhw70og9Yv5X3xtjjoFP5JYxIe+nSikeCCJIKmtM2lhECBHKNDDsMZoAUJilSVMs/i2nS5OOLl9USrgEwBfgOsfLh938xBm4XKyhrxoKqsonPJgxY2837Am7DrFJCa8H11BH6h7VM/vlAwXy5rpWBpossb1h4k+C/TPdcmToYfB+6pI2VqVctUtUJILuSdazZqxD49UrTlKZo2eulunpYk47USfnNlSTfeM+FqPEYZhKVpTU5l25AmmbOJsjb6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=libvirt.dev; dmarc=pass action=none header.from=libvirt.dev; dkim=pass header.d=libvirt.dev; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=libvirt.dev; From: Stelios Vailakakis To: pve-devel@lists.proxmox.com Date: Thu, 26 Jun 2025 02:29:20 +0000 Message-Id: <20250626022920.1323623-1-stelios@libvirt.dev> X-Mailer: git-send-email 2.39.5 X-ClientProxiedBy: PH8PR07CA0014.namprd07.prod.outlook.com (2603:10b6:510:2cd::25) To BYAPR06MB4821.namprd06.prod.outlook.com (2603:10b6:a03:7d::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR06MB4821:EE_|CH2PR06MB6613:EE_ X-MS-Office365-Filtering-Correlation-Id: 10d8dd96-c478-4440-42e8-08ddb4595ba9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|586017|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?n6QY5d5b0FCU9Z00FfHZgE0c8zv63DB+irzV+VUWmyEOzn6pGWhXuKd28gn2?= =?us-ascii?Q?EFmNW8LtF+fIjtKc+k2uC23kOS/6QDQX0hTOcVatBRRwtQykPOCdIXaPbVee?= =?us-ascii?Q?8g33L/HJ5q5m4N5mna4M4gooBjMO4gVLUNeCfgHMt6ejNGPr/WJXbDx/VlNk?= =?us-ascii?Q?RuULBg9NGKpVdCq1qQ4ScOEXW/3+JpkZz3DCzQkbBIAIr/NM7UOcGstADbuT?= =?us-ascii?Q?CzM/HahcoROnQlHB7CoZjogIb38hNf7aS0Si1Y/bo35rQ7D4svGExsfJHaGL?= =?us-ascii?Q?v6WNcGAVl5UkjlqecNcjBGUO/qS+L4uWRi5mDVueMweQ/M18BeFffqL8SGf/?= =?us-ascii?Q?WNj0nsLY1cPbAt2MhFNr6t72IY7r0br2LDs0GOTM2LcCzy56b6R7xWjkmVOx?= =?us-ascii?Q?4xiXg0nVoGi+Czei4WX5iRrO0Y1tGKwiIBZpXi+85nV5o+E4Tn7LPEHcO0KS?= =?us-ascii?Q?GM18kUvu/pwPdpNrjnUsOhBtpUxGden0fKMSMXUC8qwvBoi7a9itot6v5xmB?= =?us-ascii?Q?vQjYZ6YXwUlgUYpggEB0xakYoIg4jFVAW1/6aVST1a/vQ/sQ4GdFO7hmvLjG?= =?us-ascii?Q?PuChOsiU8TE0OF/CFhLkKxVh9c5+L/ar9XjhPvNeVMRIkYX6Z9FEGMn5gRTQ?= =?us-ascii?Q?sIimEDydn7JKw1K77RtAnU8AvfeXK7IdDDfPjvnfUYQiISPoFuhEdRvTxw+Y?= =?us-ascii?Q?z+c34sDS/Gab4bWQ7y7yZTmCV3kJiPxadOn+PkhPtUoCV6fgpi3EccwUGxia?= =?us-ascii?Q?ZH+PVqNMoEjKyWZ+6e2LoiiMc6tvP5NOSc5VZSdXtFHwpe6a16fH1I6BSzmn?= =?us-ascii?Q?T5uiPdPZHqm9kiMAgeo+LrWkoh7M4dzGHpm7u2l8XvZn5RT+kkECTIkUxoW6?= =?us-ascii?Q?Fcsdrt6O3quPNnjjSZ39myWOEEOg33JYF7VBGxZYhwZ+UuUU8bN4FMCf77w4?= =?us-ascii?Q?W1doaFm+CAtfciSP5dyAWNDPn0V7zPMfMAy/kftoLKcPcshaxMA8abQfdxEJ?= =?us-ascii?Q?rPyj8ynQYrWL8aNiSzYHfw4AXMTiy7b2aeKQUD/zc/F9vZmccw6oHb53NCFp?= =?us-ascii?Q?0WQ/zSfAxkxhSt5XWyh+tYzvlx6C0iJkyvnyV1pVIswD8nRWfP0vSUhr89oR?= =?us-ascii?Q?ZT94pQO7Dfxkae5isfxXEvkI/4Pt3KmQ/bhk1YmBhf64lxKXuPR1JYEfmxVl?= =?us-ascii?Q?eW+N7ExyyS34deu35x8eZ7EQ4CL1kGiphBgYgY1CvCdNEPtsTOx+1t/00eMJ?= =?us-ascii?Q?VCLzlb/7tbjIsoaQ9n+NZR5rY+AoZayVBpM3aiB4a0oW1++6mJUkNywh0vE7?= =?us-ascii?Q?J+qoq3KejAVK0A32ntZmQHMrT67JXvMMiGeicKOYgZGtrxRTxvB/5U+a2T88?= =?us-ascii?Q?YqymNI0tljzYkFh0sLBo8F8DQJk1syommLavXCQxfVo32NWGZNHaXYldgSmh?= =?us-ascii?Q?xzqH+R/OJR8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR06MB4821.namprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(586017)(366016)(376014)(1800799024); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?J2icqFq6QW8jPHo5m5BO6fOrGj8+05HowaLfsygHVLS/aRAI1R37YnjVnBkR?= =?us-ascii?Q?vgm/pEvCpNw+zbBKc5olwUfjiLSGjt9crlRbqZVyr2e7ApypVYflXFs1L2oo?= =?us-ascii?Q?JkaFJlulDtKULg0DwJY3uVsZRQ4TWCLXGi1jFsaWA7mn8rGjPiUckkyiLxhY?= =?us-ascii?Q?gF+jl/C3aJgM2cmt+j+IPd4tuue/EpCEkuelHS7ipkDWAbsLpsvvarQUUKgx?= =?us-ascii?Q?YfA+FqimbgSWkjeeIN1KtaLgT21HOGPmBOodNB5EjqMfMaZgrvBkIaf2krLU?= =?us-ascii?Q?2spIZFLOjJ9j+ziOrE7VtfNbxvawcVFQtPKchP7zMconkEvrZkCyeAMsH+5y?= =?us-ascii?Q?g0F2+l56weD7uFKcdjo9LVQjMox6sqJH5MSy6gjbiI+Er8az7BRq1QC7SSZk?= =?us-ascii?Q?TgJN7Lr5idsEv9OVT0BwiDM9cezYwrV32CIceZOyGOHESL/oT95keK63R/0M?= =?us-ascii?Q?4AuM64n01VN/SrNy02iVnzMAe4SwjphNY7eZ3Igh0yuAOO2NtfQd6jJAfLqo?= =?us-ascii?Q?QLZME3Ia7C9BLoWKH1AfTsOVwAXH/sjr0vtM5yZ5fIUDxhYa5E2nWFeVIpr7?= =?us-ascii?Q?dWODPaUwuW0ktMPVYEb/yml2H3BQGXxm5e66WMi/f4p4RaO9EMybTW+cOdAc?= =?us-ascii?Q?JY3hPkWLdSU8F17t+F5Ju7VPlqiea7AIc8WZ9Zlj1x98m4rsL0FhRtxAftKM?= =?us-ascii?Q?GNmRyxBfRm9jnQAddnXCcvTTqWjdJjNXVtTiXO/RslSvKcWE74Bmo/RM6FFG?= =?us-ascii?Q?ikVN+qxxuZ9r2uHqGs7isYBJMhx173RlhwYTMryCIo1IuNNPSx420UAWEwGo?= =?us-ascii?Q?5xwu2Sc7OK6XhLUEyZBZsAecHPwlpu+s/18mZj+gIZaEy1ki1gJDhoWOPji9?= =?us-ascii?Q?01qW2tMlZfyRcwS4boJ9Pi08BUnU0TBVCDZCnj0r80adxcJtLit84p09gQT7?= =?us-ascii?Q?NQDmFHnMJteIGnoa+ItytiVD7Yf5tdR9HrsGtM/CqPeAdqbeVxiXjeQmutCc?= =?us-ascii?Q?vvTQt4tU91QdjhXsgHSSHH1Rsn3BE/ItfIPYZoKMvs3YJILoiYbQJUXwU6Qw?= =?us-ascii?Q?gRm6Algxt7KwInJ6K1pPNhFAFi0FHtF6qE6NZWqXPQDjZkZoLfIwbrlDIypF?= =?us-ascii?Q?kR5hg/QCAOyUGgDRk/nBQfJjihUX3mqZ0o+9NWNXBu/S7oXRM1oq7cw6F/Hl?= =?us-ascii?Q?nfevmC70NnIotInrJ7uPNSnnOE88n+Z+YZ9ib7jhwiWP8eMKwbo9cvwo4m0L?= =?us-ascii?Q?7xyrd3pjnTvNr548/8dyaTp+C0IXlRCleGrgbTKtO2C8kiPg1+ax0tT7RNHr?= =?us-ascii?Q?wYJFijWM28w0dQeKFysYRNeiIWBA781kbBmeosUu2ooErL+c001BiZ9/5TW1?= =?us-ascii?Q?05I5/06y+e/fa6U/Tv4VLSj3fdt78lVtGcqaLlGUBflEr4STMYy0oHJAS/RJ?= =?us-ascii?Q?1XJH1WhhIMmV+QaK/AyeDbBtMtl6ByI256Ff+P+DXpQJxvNArTmHXsHG1ps1?= =?us-ascii?Q?AWB2JxJnX8PCOjEny3xYBvfZUGe74dRUgT/bG37AkqRLFnjvDyI877x9k5sF?= =?us-ascii?Q?KrUSdfnFmxtFMaItI1xx1gdpJYJWLWNRd3N/4n7y?= X-OriginatorOrg: libvirt.dev X-MS-Exchange-CrossTenant-Network-Message-Id: 10d8dd96-c478-4440-42e8-08ddb4595ba9 X-MS-Exchange-CrossTenant-AuthSource: BYAPR06MB4821.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2025 02:30:04.4919 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: ae52e033-9978-468d-bec0-1b48967ffa38 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3kfUyfmKwDrt4rWpcC9O/Ac0j+xcrFI+NZcWsf2OUap0OIIffsZf1L3bV/dblxlO5YVGhJCBJP3Y7922wes18g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR06MB6613 X-SPAM-LEVEL: Spam detection results: 0 ARC_SIGNED 0.001 Message has a ARC signature ARC_VALID 0.001 Message has a valid ARC signature AWL -0.699 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy FROM_FMBLA_NEWDOM 1.499 From domain was registered in last 7 days KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [iscsiplugin.pm] Subject: [pve-devel] [PATCH storage] iscsi: add hostname support in portal addresses X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Currently, the iSCSI plugin regex patterns only match IPv4 and IPv6 addresses, causing session parsing to fail when portals use hostnames (like nas.example.com:3260). This patch updates ISCSI_TARGET_RE and session parsing regex to accept any non-whitespace characters before the port, allowing hostname-based portals to work correctly. Tested with IP and hostname-based portals on Proxmox VE 8.2, 8.3, and 8.4.1 Signed-off-by: Stelios Vailakakis --- src/PVE/Storage/ISCSIPlugin.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/Storage/ISCSIPlugin.pm b/src/PVE/Storage/ISCSIPlugin.pm index 7691ec6..33b3d19 100644 --- a/src/PVE/Storage/ISCSIPlugin.pm +++ b/src/PVE/Storage/ISCSIPlugin.pm @@ -33,7 +33,7 @@ my sub assert_iscsi_support { } # Example: 192.168.122.252:3260,1 iqn.2003-01.org.linux-iscsi.proxmox-nfs.x8664:sn.00567885ba8f -my $ISCSI_TARGET_RE = qr/^((?:$IPV4RE|\[$IPV6RE\]):\d+)\,\S+\s+(\S+)\s*$/; +my $ISCSI_TARGET_RE = qr/^(\S+:\d+)\,\S+\s+(\S+)\s*$/; sub iscsi_session_list { assert_iscsi_support(); @@ -49,7 +49,7 @@ sub iscsi_session_list { my $line = shift; # example: tcp: [1] 192.168.122.252:3260,1 iqn.2003-01.org.linux-iscsi.proxmox-nfs.x8664:sn.00567885ba8f (non-flash) if ($line =~ - m/^tcp:\s+\[(\S+)\]\s+((?:$IPV4RE|\[$IPV6RE\]):\d+)\,\S+\s+(\S+)\s+\S+?\s*$/ + m/^tcp:\s+\[(\S+)\]\s+(\S+:\d+)\,\S+\s+(\S+)\s+\S+?\s*$/ ) { my ($session_id, $portal, $target) = ($1, $2, $3); # there can be several sessions per target (multipath) -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel