[pve-devel] [PATCH container/manager 0/3] vzdump: Switch default PBS change detection mode

[pve-devel] [PATCH container/manager 0/3] vzdump: Switch default PBS change detection mode

[Christian Ebner]

Switch the default change detection mode used by vzdump for container backups
with PBS storage target from the current `legacy` to the `metadata` mode.

The `legacy` mode was kept to avoid a breaking change in backup behavior. With
the upcoming PVE 9, switch the default to the `metadata` mode, so all container
backups can profit from the speedup by this mode. The `legacy` mode can still be
set as fallback for one-shot backups or backup jobs in the advanced
configuration options.

container:

Christian Ebner (1):
  vzdump: switch default PBS change detection mode to `metadata`

 src/PVE/VZDump/LXC.pm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)


manager:

Christian Ebner (2):
  ui: add dedicated form for PBS change detecton mode selector
  ui: switch default and extend options for PBS change detection mode

 www/manager6/Makefile                               |  1 +
 www/manager6/form/PbsChangeDetectionModeSelector.js | 11 +++++++++++
 www/manager6/panel/BackupAdvancedOptions.js         |  8 +-------
 www/manager6/window/Backup.js                       |  8 +-------
 4 files changed, 14 insertions(+), 14 deletions(-)
 create mode 100644 www/manager6/form/PbsChangeDetectionModeSelector.js


Summary over all repositories:
  5 files changed, 18 insertions(+), 16 deletions(-)

-- 
Generated by git-murpp 0.8.1


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH container 1/1] vzdump: switch default PBS change detection mode to `metadata`

[Christian Ebner]

Since commit 58839940 ("vzdump: conditionally set PBS change
detection mode option") it is possible to perform container backups
with Proxmox Backup Server as target using additional `data` and
`metadata` modes provided by the Proxmox Backup client.

While the `metadata` mode was introduced to speed up file level
backups [0], the `legacy` mode was kept as default to not
unexpectedly change the mode for container backups.

Switch the default mode to `metadata` for the upcoming Proxmox
Virtual Environment 9 release. By explicitly setting the mode, this
is independent from the PBS client's default.

[0] https://bugzilla.proxmox.com/show_bug.cgi?id=3174

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
NOTE: Assumes repo pre-formatted with proxmox-perltidy to apply

 src/PVE/VZDump/LXC.pm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/PVE/VZDump/LXC.pm b/src/PVE/VZDump/LXC.pm
index c10a4c9..84a6e02 100644
--- a/src/PVE/VZDump/LXC.pm
+++ b/src/PVE/VZDump/LXC.pm
@@ -465,8 +465,10 @@ sub archive {
         push @$param, '--backup-type', 'ct';
         push @$param, '--backup-id', $vmid;
         push @$param, '--backup-time', $task->{backup_time};
-        push @$param, '--change-detection-mode', $opts->{"pbs-change-detection-mode"}
-            if $opts->{"pbs-change-detection-mode"};
+        push @$param, '--change-detection-mode',
+            $opts->{"pbs-change-detection-mode"}
+            ? $opts->{"pbs-change-detection-mode"}
+            : 'metadata';
 
         if (my $entries_max = $opts->{"performance"}->{"pbs-entries-max"}) {
             push $param->@*, '--entries-max', $entries_max;
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 1/2] ui: add dedicated form for PBS change detecton mode selector

[Christian Ebner]

Reduce duplicate code by merging common parts of the change detection
mode selector. Allows to control a common selector used by the
advanced options of the backup job and the window for one-shot backup
runs in one place.

No functional changes intended.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
NOTE: Assumes repo pre-formatted with proxmox-biome to apply

 www/manager6/Makefile                               |  1 +
 www/manager6/form/PbsChangeDetectionModeSelector.js | 10 ++++++++++
 www/manager6/panel/BackupAdvancedOptions.js         |  8 +-------
 www/manager6/window/Backup.js                       |  8 +-------
 4 files changed, 13 insertions(+), 14 deletions(-)
 create mode 100644 www/manager6/form/PbsChangeDetectionModeSelector.js

diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index fdf0e816..255271c5 100644
--- a/www/manager6/Makefile
+++ b/www/manager6/Makefile
@@ -55,6 +55,7 @@ JSSRC= 							\
 	form/NotificationModeSelector.js		\
 	form/NotificationTargetSelector.js		\
 	form/NotificationPolicySelector.js		\
+	form/PbsChangeDetectionModeSelector.js		\
 	form/PCISelector.js				\
 	form/PCIMapSelector.js				\
 	form/PermPathSelector.js			\
diff --git a/www/manager6/form/PbsChangeDetectionModeSelector.js b/www/manager6/form/PbsChangeDetectionModeSelector.js
new file mode 100644
index 00000000..6e55aabd
--- /dev/null
+++ b/www/manager6/form/PbsChangeDetectionModeSelector.js
@@ -0,0 +1,10 @@
+Ext.define('PVE.form.PBSChangeDetectionModeSelector', {
+    extend: 'Proxmox.form.KVComboBox',
+    alias: ['widget.pbsChangeDetectionModeSelector'],
+    deleteEmpty: true,
+    comboItems: [
+        ['__default__', 'Default'],
+        ['data', 'Data'],
+        ['metadata', 'Metadata'],
+    ],
+});
diff --git a/www/manager6/panel/BackupAdvancedOptions.js b/www/manager6/panel/BackupAdvancedOptions.js
index fe8cc3bf..32fe4de5 100644
--- a/www/manager6/panel/BackupAdvancedOptions.js
+++ b/www/manager6/panel/BackupAdvancedOptions.js
@@ -276,16 +276,10 @@ Ext.define('PVE.panel.BackupAdvancedOptions', {
         {
             xtype: 'pveTwoColumnContainer',
             startColumn: {
-                xtype: 'proxmoxKVComboBox',
+                xtype: 'pbsChangeDetectionModeSelector',
                 fieldLabel: gettext('PBS change detection mode'),
                 name: 'pbs-change-detection-mode',
-                deleteEmpty: true,
                 value: '__default__',
-                comboItems: [
-                    ['__default__', 'Default'],
-                    ['data', 'Data'],
-                    ['metadata', 'Metadata'],
-                ],
             },
             endFlex: 2,
             endColumn: {
diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js
index 00ccce4b..d4542453 100644
--- a/www/manager6/window/Backup.js
+++ b/www/manager6/window/Backup.js
@@ -54,17 +54,11 @@ Ext.define('PVE.window.Backup', {
         });
 
         let pbsChangeDetectionModeSelector = Ext.create({
-            xtype: 'proxmoxKVComboBox',
+            xtype: 'pbsChangeDetectionModeSelector',
             flex: 1,
             disabled: true,
             name: 'pbs-change-detection-mode',
-            deleteEmpty: true,
             value: '__default__',
-            comboItems: [
-                ['__default__', 'Default'],
-                ['data', 'Data'],
-                ['metadata', 'Metadata'],
-            ],
         });
 
         let pbsChangeDetection = Ext.create('Ext.form.FieldContainer', {
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager 2/2] ui: switch default and extend options for PBS change detection mode

[Christian Ebner]

Switch the current implied default `legacy` option with the new
default value `metadata`, as set by vzdump.

Further, allow to switch back to the previous default by adding the
`legacy` option and keep the `metadata` mode as separate, dedicated
option so pre-exiting backup job configurations still work as
expected.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
NOTE: Assumes repo pre-formatted with proxmox-biome to apply

 www/manager6/form/PbsChangeDetectionModeSelector.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/www/manager6/form/PbsChangeDetectionModeSelector.js b/www/manager6/form/PbsChangeDetectionModeSelector.js
index 6e55aabd..e5a6c20f 100644
--- a/www/manager6/form/PbsChangeDetectionModeSelector.js
+++ b/www/manager6/form/PbsChangeDetectionModeSelector.js
@@ -3,8 +3,9 @@ Ext.define('PVE.form.PBSChangeDetectionModeSelector', {
     alias: ['widget.pbsChangeDetectionModeSelector'],
     deleteEmpty: true,
     comboItems: [
-        ['__default__', 'Default'],
+        ['__default__', 'Default (Metadata)'],
         ['data', 'Data'],
         ['metadata', 'Metadata'],
+        ['legacy', 'Legacy'],
     ],
 });
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel