From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id B08831FF170
for <inbox@lore.proxmox.com>; Thu, 15 May 2025 10:31:45 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 705EC1CD69;
Thu, 15 May 2025 10:32:07 +0200 (CEST)
From: Hannes Duerr <h.duerr@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Thu, 15 May 2025 10:31:48 +0200
Message-Id: <20250515083148.11897-1-h.duerr@proxmox.com>
X-Mailer: git-send-email 2.39.5
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.061 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH proxmox-perl-rs] pve-rs: remove
PVE::RS::APT:Repositories module
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
We can remove the PVE::RS::APT::Repositories module because we needed
its functionality in Proxmox VE and other products, so we moved it to
Proxmox::RS::APT::Repositories some time ago. We now only use the new
module in our code.
When users update to Proxmox VE 9, we can be sure that there is no
package using PVE::RS::APT::Repositories, so we can safely remove the
code.
Signed-off-by: Hannes Duerr <h.duerr@proxmox.com>
---
This patch should only be applied with Proxmox VE version 9
pve-rs/Makefile | 1 -
pve-rs/src/apt/mod.rs | 1 -
pve-rs/src/apt/repositories.rs | 42 ----------------------------------
pve-rs/src/lib.rs | 1 -
4 files changed, 45 deletions(-)
delete mode 100644 pve-rs/src/apt/mod.rs
delete mode 100644 pve-rs/src/apt/repositories.rs
diff --git a/pve-rs/Makefile b/pve-rs/Makefile
index ae7f2e2..9ca6e64 100644
--- a/pve-rs/Makefile
+++ b/pve-rs/Makefile
@@ -27,7 +27,6 @@ PERLMOD_GENPACKAGE := /usr/lib/perlmod/genpackage.pl \
--include-file=Fixup.pm
PERLMOD_PACKAGES := \
- PVE::RS::APT::Repositories \
PVE::RS::Firewall::SDN \
PVE::RS::OpenId \
PVE::RS::ResourceScheduling::Static \
diff --git a/pve-rs/src/apt/mod.rs b/pve-rs/src/apt/mod.rs
deleted file mode 100644
index 574c1a7..0000000
--- a/pve-rs/src/apt/mod.rs
+++ /dev/null
@@ -1 +0,0 @@
-mod repositories;
diff --git a/pve-rs/src/apt/repositories.rs b/pve-rs/src/apt/repositories.rs
deleted file mode 100644
index 7fbf97c..0000000
--- a/pve-rs/src/apt/repositories.rs
+++ /dev/null
@@ -1,42 +0,0 @@
-#[perlmod::package(name = "PVE::RS::APT::Repositories", lib = "pve_rs")]
-mod export {
- use anyhow::Error;
-
- use proxmox_apt_api_types::{
- APTChangeRepositoryOptions, APTRepositoriesResult, APTRepositoryHandle,
- };
- use proxmox_config_digest::ConfigDigest;
-
- use crate::common::apt::repositories::export as common;
-
- /// Get information about configured and standard repositories.
- #[export]
- pub fn repositories() -> Result<APTRepositoriesResult, Error> {
- proxmox_apt::list_repositories("pve")
- }
-
- /// Add the repository identified by the `handle`.
- /// If the repository is already configured, it will be set to enabled.
- ///
- /// The `digest` parameter asserts that the configuration has not been modified.
- #[export]
- pub fn add_repository(
- handle: APTRepositoryHandle,
- digest: Option<ConfigDigest>,
- ) -> Result<(), Error> {
- common::add_repository(handle, "pve", digest)
- }
-
- /// Change the properties of the specified repository.
- ///
- /// The `digest` parameter asserts that the configuration has not been modified.
- #[export]
- pub fn change_repository(
- path: &str,
- index: usize,
- options: APTChangeRepositoryOptions,
- digest: Option<ConfigDigest>,
- ) -> Result<(), Error> {
- common::change_repository(path, index, options, digest)
- }
-}
diff --git a/pve-rs/src/lib.rs b/pve-rs/src/lib.rs
index 3de37d1..755db12 100644
--- a/pve-rs/src/lib.rs
+++ b/pve-rs/src/lib.rs
@@ -11,7 +11,6 @@ use proxmox_notify::{Config, Notification, Severity};
#[path = "../common/src/mod.rs"]
pub mod common;
-pub mod apt;
pub mod firewall;
pub mod openid;
pub mod resource_scheduling;
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel