From: Friedrich Weber <f.weber@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH kernel] debian: find firmware: quote regex metacharacters in directory name
Date: Mon, 28 Apr 2025 18:34:12 +0200 [thread overview]
Message-ID: <20250428163412.3670859-1-f.weber@proxmox.com> (raw)
The directory name contains the version which may contain characters
with semantics as regex metacharacters, e.g. `+` when building a test
kernel. If they are not quoted, the script does not remove the
directory name from its output, which will cause a build failure in
`fwcheck` even though the firmware did not change.
To avoid that, quote metacharacters in the directory name.
Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
---
debian/scripts/find-firmware.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/scripts/find-firmware.pl b/debian/scripts/find-firmware.pl
index a53223c..5c458bb 100755
--- a/debian/scripts/find-firmware.pl
+++ b/debian/scripts/find-firmware.pl
@@ -17,7 +17,7 @@ open(my $FIND_KO_FH, "find '$dir' -name '*.ko'|");
while (defined(my $fn = <$FIND_KO_FH>)) {
chomp $fn;
my $relfn = $fn;
- $relfn =~ s|^$dir/*||;
+ $relfn =~ s|^\Q$dir\E/*||;
my $cmd = "/sbin/modinfo -F firmware '$fn'";
open(my $MOD_FH, "$cmd|");
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next reply other threads:[~2025-04-28 16:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 16:34 Friedrich Weber [this message]
2025-05-08 18:27 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250428163412.3670859-1-f.weber@proxmox.com \
--to=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.