From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id CF9441FF16E for ; Mon, 14 Apr 2025 14:00:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D3FB63196B; Mon, 14 Apr 2025 14:00:59 +0200 (CEST) From: Gabriel Goller To: pdm-devel@lists.proxmox.com Date: Mon, 14 Apr 2025 14:00:43 +0200 Message-Id: <20250414120046.486853-2-g.goller@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250414120046.486853-1-g.goller@proxmox.com> References: <20250414120046.486853-1-g.goller@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH proxmox 1/3] section-config: make write_section_config parameter more generic X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" The underlying function which gets called by `write_section_config` also takes a `impl AsRef` and in some cases we do pass a path, so taking the same parameter is better. Signed-off-by: Gabriel Goller --- proxmox-section-config/src/typed.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/proxmox-section-config/src/typed.rs b/proxmox-section-config/src/typed.rs index 31e8e4b2e546..a25798e8a29b 100644 --- a/proxmox-section-config/src/typed.rs +++ b/proxmox-section-config/src/typed.rs @@ -1,6 +1,7 @@ //! Support for `enum` typed section configs. use std::collections::HashMap; +use std::path::Path; use anyhow::Error; use serde::{de::DeserializeOwned, Serialize}; @@ -90,7 +91,7 @@ pub trait ApiSectionDataEntry: Sized { } /// Provided. Shortcut for `Self::section_config().write(filename, &data.try_into()?)`. - fn write_section_config(filename: &str, data: &SectionConfigData) -> Result + fn write_section_config(filename: impl AsRef, data: &SectionConfigData) -> Result where Self: Serialize, { -- 2.39.5 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel