From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4202C1FF16E for ; Mon, 14 Apr 2025 14:01:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EBE87319D1; Mon, 14 Apr 2025 14:01:02 +0200 (CEST) From: Gabriel Goller To: pdm-devel@lists.proxmox.com Date: Mon, 14 Apr 2025 14:00:42 +0200 Message-Id: <20250414120046.486853-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pdm-devel] [PATCH proxmox{, -datacenter-manager} 0/4] Remove direct access to SectionConfigData sections X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" This patch series removes direct access to SectionConfigData. Previously, one could directly access and add sections by using DerefMut and the public `sections` HashMap property. This created a significant risk of not updating the `order` Vector, which maintains the section sequence to ensure consistent read and write ordering. To address this issue, this patch removes the DerefMut implementation and makes both `sections` and `order` private. Read access remains available through the Deref implementation for the `sections` HashMap, while write access is now provided through newly introduced helper methods: `insert`, `remove`, and `get_mut`. This is a breaking change that affects multiple `SectionConfigData` usages. Since SectionConfigData is primarily used in the proxmox-datacenter-manager, all usages there have been updated accordingly. A follow-up patch series is in preparation that will convert untyped SectionConfigData to typed SectionConfigData, which provides better usability and eliminates the need for frequent serialization and deserialization operations. proxmox: Gabriel Goller (3): section-config: make write_section_config parameter more generic section-config: remove DerefMut and make underlying HashMap private section-config: add lookup and convert_to_typed_array helpers proxmox-section-config/Cargo.toml | 3 + proxmox-section-config/src/typed.rs | 189 ++++++++++++++++++++++++++-- 2 files changed, 183 insertions(+), 9 deletions(-) proxmox-datacenter-manager: Gabriel Goller (1): remotes: remove direct access on underlying sections HashMap server/src/api/resources.rs | 2 +- server/src/metric_collection/mod.rs | 8 ++++---- server/src/remote_tasks/mod.rs | 6 +++--- server/src/test_support/fake_remote.rs | 9 +++------ 4 files changed, 11 insertions(+), 14 deletions(-) Summary over all repositories: 6 files changed, 194 insertions(+), 23 deletions(-) -- Generated by git-murpp 0.8.0 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel