From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id AB3341FF172 for ; Tue, 1 Apr 2025 10:27:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A836D1C405; Tue, 1 Apr 2025 10:27:06 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 1 Apr 2025 10:26:30 +0200 Message-Id: <20250401082630.9727-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250331132020.105324-1-f.ebner@proxmox.com> References: <20250331132020.105324-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.038 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [FOLLOWUP storage] backup provider: base: document limitation of backup_container() method X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The backup_container() method is called after forking, so changes to $self will not be visible in later method calls done by the parent. Signed-off-by: Fiona Ebner --- src/PVE/BackupProvider/Plugin/Base.pm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/PVE/BackupProvider/Plugin/Base.pm b/src/PVE/BackupProvider/Plugin/Base.pm index 424feb7..4a35330 100644 --- a/src/PVE/BackupProvider/Plugin/Base.pm +++ b/src/PVE/BackupProvider/Plugin/Base.pm @@ -595,11 +595,16 @@ that is made available for the mechanism returned by C. Returns when done backing up. Ideally, the method should log the progress during backup. -Note that this function is executed as the ID-mapped root user of the container, +Note that this method is executed as the ID-mapped root user of the container, so a potentially unprivileged user. The ID is passed along as part of C<$info>. Use the C method for preparation. For example, to make credentials available to the potentially unprivileged user. +Note that changes to C<$self> made during this method will not be visible in +later method calls. This is because the method is executed in a separate +execution context after forking. Use the C method +if you need persistent changes to C<$self>. + Parameters: =over -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel