From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A27CD1FF168 for ; Tue, 4 Mar 2025 11:45:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B7A691B592; Tue, 4 Mar 2025 11:44:54 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 4 Mar 2025 11:44:11 +0100 Message-Id: <20250304104413.38638-11-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250304104413.38638-1-f.ebner@proxmox.com> References: <20250304104413.38638-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server 10/12] backup: include owned CD-ROM volumes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Currently, all volumes with a 'media=cdrom' marker are excluded from backup. For owned volumes, this is very surprising. Treat owned CD-ROM volumes like other volumes and consider the 'backup' marker instead. Cloud-init volumes are owned, but still skipped, because they are generated from the configuration/snippets. Stay compatible with old callers avoiding the need for a versioned breaks. Signed-off-by: Fiona Ebner --- PVE/QemuConfig.pm | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/PVE/QemuConfig.pm b/PVE/QemuConfig.pm index 43967b43..92b21259 100644 --- a/PVE/QemuConfig.pm +++ b/PVE/QemuConfig.pm @@ -172,12 +172,20 @@ sub get_replicatable_volumes { sub get_backup_volumes { my ($class, $conf, $vmid) = @_; + my $storecfg = PVE::Storage::config(); + my $return_volumes = []; my $test_volume = sub { my ($key, $drive) = @_; - return if PVE::QemuServer::drive_is_cdrom($drive); + if (PVE::QemuServer::Drive::drive_is_cdrom($drive)) { + return if !defined($vmid); # for compat - TODO PVE 9 - remove + my $owned = PVE::QemuServer::Drive::vm_is_volid_owner($storecfg, $vmid, $drive->{file}); + my $is_cloudinit = PVE::QemuServer::Drive::drive_is_cloudinit($drive); + + return if !$owned || $is_cloudinit; + } my $included = $drive->{backup} // 1; my $reason = "backup="; -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel