From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id BAE141FF15C for ; Wed, 19 Feb 2025 12:18:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3C0B51ECD4; Wed, 19 Feb 2025 12:17:45 +0100 (CET) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Date: Wed, 19 Feb 2025 12:17:40 +0100 Message-Id: <20250219111740.200819-7-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250219111740.200819-1-m.sandoval@proxmox.com> References: <20250219111740.200819-1-m.sandoval@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.146 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URI_NOVOWEL 0.5 URI hostname has long non-vowel sequence Subject: [pve-devel] [PATCH storage v4 7/7] btrfs: rename snapshot parameter X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" It was originally introduced as $snapshot to match the argument name of foreach_subvol, we rename it here to make it clear that it only contains the snapshot name. Signed-off-by: Maximiliano Sandoval --- src/PVE/Storage/BTRFSPlugin.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/PVE/Storage/BTRFSPlugin.pm b/src/PVE/Storage/BTRFSPlugin.pm index c82d5f7..a28996c 100644 --- a/src/PVE/Storage/BTRFSPlugin.pm +++ b/src/PVE/Storage/BTRFSPlugin.pm @@ -407,18 +407,18 @@ my sub path_is_subvolume : prototype($) { my $BTRFS_SNAPSHOT_REGEX = qr/((?:vm|base|subvol)-\d+-disk-\d+(?:\.subvol)?)(?:\@(\S+))$/; -# Calls `$code->($snapshot)` for each snapshot of the BTRFS subvolume. +# Calls `$code->($snap_name)` for each snapshot of the BTRFS subvolume. my sub foreach_snapshot_of_subvol : prototype($$) { my ($subvol, $code) = @_; my $basename = basename($subvol); my $dir = dirname($subvol); dir_glob_foreach($dir, $BTRFS_SNAPSHOT_REGEX, sub { - my ($volume, $name, $snapshot) = ($1, $2, $3); + my ($volume, $name, $snap_name) = ($1, $2, $3); return if !path_is_subvolume("$dir/$volume"); return if $name ne $basename; - return if !defined $snapshot; - $code->($snapshot); + return if !defined $snap_name; + $code->($snap_name); }); } -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel