From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 41C5B1FF15C for ; Wed, 19 Feb 2025 11:10:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 380311CBC9; Wed, 19 Feb 2025 11:09:54 +0100 (CET) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Wed, 19 Feb 2025 11:09:46 +0100 Message-Id: <20250219100949.54413-2-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250219100949.54413-1-s.hanreich@proxmox.com> References: <20250219100949.54413-1-s.hanreich@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.242 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [firewall.rs] Subject: [pve-devel] [PATCH proxmox-firewall 1/4] ipsets: remove dereference X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The network device configuration doesn't return a reference anymore, so we do not need to dereference here anymore. Signed-off-by: Stefan Hanreich --- Notes: This and the subsequent tests patch require a bump of proxmox-ve-config to work proxmox-firewall/src/firewall.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/proxmox-firewall/src/firewall.rs b/proxmox-firewall/src/firewall.rs index 88fb460..e980bd5 100644 --- a/proxmox-firewall/src/firewall.rs +++ b/proxmox-firewall/src/firewall.rs @@ -801,11 +801,11 @@ impl Firewall { ipset.push(cidr.into()); if let Some(ip_address) = network_device.ip() { - ipset.push(IpsetEntry::from(*ip_address)); + ipset.push(IpsetEntry::from(ip_address)); } if let Some(ip6_address) = network_device.ip6() { - ipset.push(IpsetEntry::from(*ip6_address)); + ipset.push(IpsetEntry::from(ip6_address)); } commands.append(&mut ipset.to_nft_objects(&env)?); -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel