From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] [PATCH datacenter-manager 2/2] ui: remote tasks: make column sizes a bit more dynamic
Date: Thu, 23 Jan 2025 15:41:04 +0100 [thread overview]
Message-ID: <20250123144104.3849889-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20250123144104.3849889-1-d.csapak@proxmox.com>
make the user/remote/node/status relative in size to the description
(while keeping the current size as minimum).
This makes it more usable by default when those fields contain longer
text.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
ui/src/remotes/tasks.rs | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/ui/src/remotes/tasks.rs b/ui/src/remotes/tasks.rs
index 6474035..99bb243 100644
--- a/ui/src/remotes/tasks.rs
+++ b/ui/src/remotes/tasks.rs
@@ -51,13 +51,13 @@ fn columns() -> Rc<Vec<DataTableHeader<TaskListItem>>> {
})
.into(),
DataTableColumn::new(tr!("User name"))
- .width("150px")
+ .width("minmax(150px, 1fr)")
.render(|item: &TaskListItem| {
html! {&item.user}
})
.into(),
DataTableColumn::new(tr!("Remote"))
- .width("150px")
+ .width("minmax(150px, 1fr)")
.render(
|item: &TaskListItem| match item.upid.parse::<RemoteUpid>() {
Ok(remote) => html! {remote.remote()},
@@ -66,13 +66,13 @@ fn columns() -> Rc<Vec<DataTableHeader<TaskListItem>>> {
)
.into(),
DataTableColumn::new(tr!("Node"))
- .width("150px")
+ .width("minmax(150px, 1fr)")
.render(|item: &TaskListItem| {
html! {&item.node}
})
.into(),
DataTableColumn::new(tr!("Description"))
- .flex(1)
+ .flex(4)
.render(move |item: &TaskListItem| {
if let Ok(remote_upid) = item.upid.parse::<RemoteUpid>() {
match remote_upid.upid.parse::<PveUpid>() {
@@ -88,7 +88,7 @@ fn columns() -> Rc<Vec<DataTableHeader<TaskListItem>>> {
})
.into(),
DataTableColumn::new(tr!("Status"))
- .width("200px")
+ .width("minmax(200px, 1fr)")
.render(|item: &TaskListItem| {
let text = item.status.as_deref().unwrap_or("");
html! {text}
--
2.39.5
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-01-23 14:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 14:41 [pdm-devel] [PATCH yew-comp] " Dominik Csapak
2025-01-23 14:41 ` [pdm-devel] [PATCH datacenter-manager 1/2] ui: remote selector: update remotes when context changes Dominik Csapak
2025-01-23 14:41 ` Dominik Csapak [this message]
2025-01-28 15:18 ` [pdm-devel] applied: [PATCH yew-comp] tasks: make column sizes a bit more dynamic Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250123144104.3849889-3-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.