[pdm-devel] [PATCH proxmox-yew-comp 02/15] remove needless casts

[Maximiliano Sandoval <m.sandoval@proxmox.com>]

Fixes:

warning: casting to the same type is unnecessary (`f64` -> `f64`)
   --> src/rrd_graph_new.rs:514:23
    |
514 |                     + (((t - start_time) as f64 * width) as f64) / time_span
    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((t - start_time) as f64 * width)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

warning: casting float literal to `f64` is unnecessary
   --> src/rrd_graph_new.rs:208:20
    |
208 |     while (range / (2.0 as f64).powi(l)) < 4.0 {
    |                    ^^^^^^^^^^^^ help: try: `2.0_f64`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/rrd_graph_new.rs | 10 +++++-----
 src/rrd_grid.rs      |  4 ++--
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/rrd_graph_new.rs b/src/rrd_graph_new.rs
index 2d1db13..00fa39a 100644
--- a/src/rrd_graph_new.rs
+++ b/src/rrd_graph_new.rs
@@ -179,11 +179,11 @@ fn get_grid_unit_base10(min: f64, max: f64) -> f64 {
 
     let mut l = range.log10() as i32;
 
-    while (range / (10.0 as f64).powi(l)) < 2.0 {
+    while (range / 10.0_f64.powi(l)) < 2.0 {
         l -= 1;
     }
 
-    let mut res = (10.0 as f64).powi(l);
+    let mut res = 10.0_f64.powi(l);
 
     let count = range / res;
 
@@ -205,11 +205,11 @@ fn get_grid_unit_base2(min: f64, max: f64) -> f64 {
 
     let mut l = range.log2() as i32;
 
-    while (range / (2.0 as f64).powi(l)) < 4.0 {
+    while (range / 2.0_f64.powi(l)) < 4.0 {
         l -= 1;
     }
 
-    let mut res = (2.0 as f64).powi(l);
+    let mut res = 2.0_f64.powi(l);
 
     let count = range / res;
 
@@ -511,7 +511,7 @@ impl PwtRRDGraph {
             let width = (layout.width - layout.left_offset - layout.grid_border * 2) as f64;
             move |t: i64| -> f64 {
                 (layout.left_offset + layout.grid_border) as f64
-                    + (((t - start_time) as f64 * width) as f64) / time_span
+                    + ((t - start_time) as f64 * width) / time_span
             }
         };
 
diff --git a/src/rrd_grid.rs b/src/rrd_grid.rs
index 9ad3d7d..5432b72 100644
--- a/src/rrd_grid.rs
+++ b/src/rrd_grid.rs
@@ -45,11 +45,11 @@ impl Component for ProxmoxRRDGrid {
                 let cw = 800;
                 let width = width.max(cw);
                 let padding = 6;
-                let mut cols = (width / cw) as usize;
+                let mut cols = width / cw;
                 if cols == 0 {
                     cols = 1;
                 }
-                let col_width = (width as usize - 2 * padding) / cols;
+                let col_width = (width - 2 * padding) / cols;
                 self.cols = cols;
                 self.col_width = col_width - padding;
                 true
-- 
2.39.5



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel