From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9A26C1FF15C for ; Wed, 13 Nov 2024 20:02:04 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BA2851BF9E; Wed, 13 Nov 2024 20:02:03 +0100 (CET) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Wed, 13 Nov 2024 20:01:13 +0100 Message-Id: <20241113190113.678807-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.079 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH] fix #5869: d/postinst: do not fail if ifreload fails on first install X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" erroring out here will not help getting a running network, therefore just log a warning. Tested the original reporters case (running in a debootstrap) with: ``` mmdebstrap \ --variant=minbase \ --include=/tmp/ifupdown2_3.2.0-1+pmx10_all.deb \ --hook-dir=/usr/share/mmdebstrap/hooks/file-mirror-automount \ bookworm \ ./bookworm-amd64.tar.zst ``` ran through our install on plain debian guide: https://pve.proxmox.com/wiki/Install_Proxmox_VE_on_Debian_12_Bookworm with this package in a local repository to check for regressions adding the reference to the commit that introduced the reload on first-install, as this got shifted around a bit and it took me too long to see that we did not want to error out here on purpose Fixes: 86335f3f898c59864a09a3e13b8146c0a0ea079d Signed-off-by: Stoiko Ivanov --- debian/ifupdown2.postinst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/ifupdown2.postinst b/debian/ifupdown2.postinst index 0137ea8..a22b825 100644 --- a/debian/ifupdown2.postinst +++ b/debian/ifupdown2.postinst @@ -114,7 +114,7 @@ case "$1" in if [ -f "/tmp/.ifupdown2-first-install" ] && [ ! -e /proxmox_install_mode ]; then proxmox_compatibility echo "Reloading network config on first install" - ifreload -a + ifreload -a || report_warn "Reloading failed" rm /tmp/.ifupdown2-first-install fi ;; -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel