all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH widget-toolkit] node/ServiceView: fix #5611: hiding the non-installed services
@ 2024-11-06 11:37 Daniel Herzig
  2024-11-08 14:02 ` Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Herzig @ 2024-11-06 11:37 UTC (permalink / raw)
  To: pve-devel

This patch adds a filter to identify services, which are reported as
'not-found' by the api. By default they will not be shown in the UI
anymore, but visibility can still be toggled using a new checkbox.

Signed-off-by: Daniel Herzig <d.herzig@proxmox.com>
---
 src/node/ServiceView.js | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/src/node/ServiceView.js b/src/node/ServiceView.js
index 19cfc18..f1c2e5f 100644
--- a/src/node/ServiceView.js
+++ b/src/node/ServiceView.js
@@ -29,6 +29,10 @@ Ext.define('Proxmox.node.ServiceView', {
 	    },
 	});
 
+	let hide_not_installed = function(record) {
+	    return record.get('unit-state') !== 'not-found';
+	};
+
 	let store = Ext.create('Proxmox.data.DiffStore', {
 	    rstore: rstore,
 	    sortAfterUpdate: true,
@@ -38,6 +42,24 @@ Ext.define('Proxmox.node.ServiceView', {
 		    direction: 'ASC',
 		},
 	    ],
+	    filters: [
+		hide_not_installed,
+	    ],
+	});
+
+	let unHideCB = Ext.create('Ext.form.field.Checkbox', {
+	    boxLabel: gettext('Show non-installed services'),
+	    value: false,
+	    boxLabelAlign: 'before',
+	    listeners: {
+		change: function(_cb, value) {
+		    if (value) {
+			store.clearFilter();
+		    } else {
+			store.addFilter([hide_not_installed]);
+		    }
+		},
+	    },
 	});
 
 	let view_service_log = function() {
@@ -166,6 +188,8 @@ Ext.define('Proxmox.node.ServiceView', {
 		restart_btn,
 		'-',
 		syslog_btn,
+		'->',
+		unHideCB,
 	    ],
 	    columns: [
 		{
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-11-08 14:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-06 11:37 [pve-devel] [PATCH widget-toolkit] node/ServiceView: fix #5611: hiding the non-installed services Daniel Herzig
2024-11-08 14:02 ` Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal