From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 05CB61FF15C for ; Wed, 21 Aug 2024 11:40:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4E26B15D8A; Wed, 21 Aug 2024 11:40:38 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Wed, 21 Aug 2024 11:40:10 +0200 Message-ID: <20240821094023.667806-9-c.heiss@proxmox.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240821094023.667806-1-c.heiss@proxmox.com> References: <20240821094023.667806-1-c.heiss@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH installer v3 08/20] common: http: pass url by reference X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Signed-off-by: Christoph Heiss --- Changes v2 -> v3: * new patch, split out from later patch proxmox-fetch-answer/src/fetch_plugins/http.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/proxmox-fetch-answer/src/fetch_plugins/http.rs b/proxmox-fetch-answer/src/fetch_plugins/http.rs index f5af226..5e10f6a 100644 --- a/proxmox-fetch-answer/src/fetch_plugins/http.rs +++ b/proxmox-fetch-answer/src/fetch_plugins/http.rs @@ -67,7 +67,7 @@ impl FetchFromHTTP { info!("Gathering system information."); let payload = SysInfo::as_json()?; info!("Sending POST request to '{answer_url}'."); - let answer = http_post::call(answer_url, fingerprint.as_deref(), payload)?; + let answer = http_post::call(&answer_url, fingerprint.as_deref(), payload)?; Ok(answer) } @@ -198,7 +198,7 @@ mod http_post { /// * `url` - URL to call /// * `fingerprint` - SHA256 cert fingerprint if certificate pinning should be used. Optional. /// * `payload` - The payload to send to the server. Expected to be a JSON formatted string. - pub fn call(url: String, fingerprint: Option<&str>, payload: String) -> Result { + pub fn call(url: &str, fingerprint: Option<&str>, payload: String) -> Result { let answer; if let Some(fingerprint) = fingerprint { @@ -210,7 +210,7 @@ mod http_post { let agent: Agent = AgentBuilder::new().tls_config(Arc::new(tls_config)).build(); answer = agent - .post(&url) + .post(url) .set("Content-type", "application/json; charset=utf-8") .send_string(&payload)? .into_string()?; @@ -230,7 +230,7 @@ mod http_post { .tls_config(Arc::new(tls_config)) .build(); answer = agent - .post(&url) + .post(url) .set("Content-type", "application/json; charset=utf-8") .timeout(std::time::Duration::from_secs(60)) .send_string(&payload)? -- 2.45.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel