From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2AAFC97C33 for <pbs-devel@lists.proxmox.com>; Wed, 6 Mar 2024 12:21:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0822B15F97 for <pbs-devel@lists.proxmox.com>; Wed, 6 Mar 2024 12:21:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pbs-devel@lists.proxmox.com>; Wed, 6 Mar 2024 12:21:05 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AE9E548836 for <pbs-devel@lists.proxmox.com>; Wed, 6 Mar 2024 12:21:05 +0100 (CET) From: Dominik Csapak <d.csapak@proxmox.com> To: pbs-devel@lists.proxmox.com Date: Wed, 6 Mar 2024 12:20:57 +0100 Message-Id: <20240306112104.2486728-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH widget-toolkit/proxmox-backup] adapt to stricter api parameter checks X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 06 Mar 2024 11:21:07 -0000 since a bit, i believe commit bae2cf75 (schema: AllOf/OneOf: actually perform additional_properties() check) in proxmox-schema, sending additional properties not defined for an api call is forbidden and leads to an error. Sadly, the gui did not adhere strictly to the api definition and sometimes sent more data that what was defined, now resulting in various api errors when using the gui. This series fixes those that i found (there are probably some that i missed). I did not include the whole detail why in every commit, but if that's preferred just holler and i add a sentence or two to every commmit. the first patch in proxmox-backup is just indentation cleanup and not really related, so could be applied independently. proxmox-widget-toolkit: Dominik Csapak (1): realms: don't send type and delete on creation src/window/AuthEditLDAP.js | 8 ++++---- src/window/AuthEditOpenId.js | 10 ---------- 2 files changed, 4 insertions(+), 14 deletions(-) proxmox-backup: Dominik Csapak (6): ui: prune job edit: indent fix ui: metrics: don't send digest when creating a new influxdbupd host ui: tape backup job: don't send delete value on creation ui: prune: fix sending invalid parameters ui: sync job: don't send delete value on creation ui: verify job: don't send delete value on creation www/datastore/Content.js | 1 + www/panel/PrunePanel.js | 2 +- www/tape/window/TapeBackupJob.js | 14 ++++++++++++++ www/window/InfluxDbEdit.js | 20 +++++++++++--------- www/window/PruneJobEdit.js | 11 ++++++++--- www/window/SyncJobEdit.js | 14 +++++++++++++- www/window/VerifyJobEdit.js | 4 +++- 7 files changed, 51 insertions(+), 15 deletions(-) -- 2.39.2