From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <c.heiss@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EDFA591834 for <pve-devel@lists.proxmox.com>; Thu, 15 Feb 2024 13:40:44 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CFF761302F for <pve-devel@lists.proxmox.com>; Thu, 15 Feb 2024 13:40:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Thu, 15 Feb 2024 13:40:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 115CE48465 for <pve-devel@lists.proxmox.com>; Thu, 15 Feb 2024 13:40:13 +0100 (CET) From: Christoph Heiss <c.heiss@proxmox.com> To: pve-devel@lists.proxmox.com Date: Thu, 15 Feb 2024 13:39:33 +0100 Message-ID: <20240215124004.1197676-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [utils.rs, parse-fqdn.pl, net.pm, proxmox.com] Subject: [pve-devel] [PATCH installer 0/5] proxinstall, tui: improve hostname/FQDN validation X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 15 Feb 2024 12:40:45 -0000 This series improves various aspects regarding FQDN handling and validation across both the GUI and TUI installer. It (partially) addresses issue #5230 [0] in patch #5, by fixing the regex through which we validate FQDNs in the GUI installer. It also refactors the FQDN validation/parsing in the GUI installer, by moving it into its own subroutine - making the whole thing bit easier to reason about, as well as adding loads of test cases. [0] https://bugzilla.proxmox.com/show_bug.cgi?id=5230 Christoph Heiss (5): common: fqdn: do not allow overlong FQDNs as per Debian spec common: fqdn: implement case-insensitive comparison as per RFC 952 proxinstall: avoid open-coding FQDN sanity check sys: net: do not allow overlong FQDNs as per RFCs and Debian spec fix #5230: sys: net: properly escape FQDN regex Proxmox/Sys/Net.pm | 29 +++++++++- proxinstall | 22 +++----- proxmox-installer-common/src/utils.rs | 79 ++++++++++++++++++++++++++- test/Makefile | 6 +- test/parse-fqdn.pl | 57 +++++++++++++++++++ 5 files changed, 172 insertions(+), 21 deletions(-) create mode 100755 test/parse-fqdn.pl -- 2.43.0