From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <c.heiss@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 10999910ED for <pve-devel@lists.proxmox.com>; Tue, 13 Feb 2024 16:14:15 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C635C3831E for <pve-devel@lists.proxmox.com>; Tue, 13 Feb 2024 16:14:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Tue, 13 Feb 2024 16:14:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C863747D16 for <pve-devel@lists.proxmox.com>; Tue, 13 Feb 2024 16:14:13 +0100 (CET) From: Christoph Heiss <c.heiss@proxmox.com> To: pve-devel@lists.proxmox.com Date: Tue, 13 Feb 2024 16:13:57 +0100 Message-ID: <20240213151405.1282639-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [run-command.pl, proxmox.com, runenv.pm, command.pm] Subject: [pve-devel] [PATCH installer v2 0/6] fix #4872: properly timeout `traceroute` command in country detection X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 13 Feb 2024 15:14:15 -0000 For all the details, see patch #6. TL;DR: SIGALRM does not interrupt line reading using <>, causing the installer to hang on country detection. Fix it by using Proxmox::Sys::Command::run_command(), which properly interacts with SIGALRM. Patch #1 is a rather mundane fix for some niche cases, #2 is a small refactoring as proposed by Thomas and #3 might warrant some more thought. #4 & #5 are preparatory and to not alter existing behaviour. v1: https://lists.proxmox.com/pipermail/pve-devel/2024-February/061677.html Changes since v1: * new patches #2 (refactoring) and #3 (EINTR handling) * introduce CMD_FINISHED constant for run_command() * added function documentation Christoph Heiss (6): low-level: initialize UI backend for 'dump-env' subcommand too sys: command: factor out kill() + waitpid() from run_command() sys: command: handle EINTR in run_command() sys: command: allow terminating the process early from log subroutine sys: command: add option to not print process output to stdout fix #4872: run env: use run_command() for country detection Proxmox/Install/RunEnv.pm | 22 +++++----- Proxmox/Sys/Command.pm | 85 ++++++++++++++++++++++++++++++++----- proxmox-low-level-installer | 1 + test/Makefile | 5 ++- test/run-command.pl | 46 ++++++++++++++++++++ 5 files changed, 137 insertions(+), 22 deletions(-) create mode 100755 test/run-command.pl -- 2.43.0