From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <g.goller@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7649FB961A for <pbs-devel@lists.proxmox.com>; Mon, 11 Dec 2023 09:59:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5817F1341C for <pbs-devel@lists.proxmox.com>; Mon, 11 Dec 2023 09:59:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pbs-devel@lists.proxmox.com>; Mon, 11 Dec 2023 09:59:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0652B44EEE for <pbs-devel@lists.proxmox.com>; Mon, 11 Dec 2023 09:59:06 +0100 (CET) From: Gabriel Goller <g.goller@proxmox.com> To: pbs-devel@lists.proxmox.com Date: Mon, 11 Dec 2023 09:59:00 +0100 Message-Id: <20231211085902.20747-1-g.goller@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.147 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pbs-devel] [PATCH v2 proxmox-backup 0/2] Fix DatastoreListSummary on limited permissions X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 11 Dec 2023 08:59:07 -0000 When the user has limited permissions on a datastore (e.g `NoAccess` on the whole datastore and `DatastoreBackup` on a namespace inside the datastore) the Datastore List shows weird values. Instead of returning -1 we return an Option and handle missing values on the frontend. Changes version 2: - Use u64 instead of i64, as value is never negative. proxmox-backup: Gabriel Goller (2): ui: datastore summary handle non-existent values status: use Option on avail/used datastore attrs pbs-api-types/src/datastore.rs | 19 +++++++++++-------- src/api2/status.rs | 6 +++--- www/datastore/DataStoreListSummary.js | 20 ++++++++++++++------ 3 files changed, 28 insertions(+), 17 deletions(-) Summary over all repositories: 3 files changed, 28 insertions(+), 17 deletions(-) -- murpp v0.4.0