From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 33F1D9D0B5 for ; Wed, 25 Oct 2023 10:57:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1560E11F93 for ; Wed, 25 Oct 2023 10:56:43 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 25 Oct 2023 10:56:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1DF01450E2 for ; Wed, 25 Oct 2023 10:56:42 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Wed, 25 Oct 2023 10:56:21 +0200 Message-ID: <20231025085634.171618-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [setup.rs, proxmox.com, bootdisk.rs, options.rs, main.rs] Subject: [pve-devel] [PATCH installer v2 0/3] tui: remove global, unsafe setup info X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2023 08:57:13 -0000 Removes the `static mut` for holding a `SetupInfo` instance. This is done by either passing the needed info as parameter, or in some cases, the needed information is already available through other means. Not only does it get rid of some ugly, unsafe code, it is needed anyway as a prerequisite by Aaron for pulling out non-TUI-related code into a separate, shared crate. No functional changes overall. v1: https://lists.proxmox.com/pipermail/pve-devel/2023-October/059335.html Changes v1 -> v2: * Rebased on latest master, no actual changes otherwise Christoph Heiss (3): tui: refactor `NetworkOptions` to have a `defaults_from()` function tui: bootdisk: pass down product info to advanced dialog tui: remove obsolete, global `SetupInfo` state proxmox-tui-installer/src/main.rs | 34 +++------- proxmox-tui-installer/src/options.rs | 75 ++++++++++----------- proxmox-tui-installer/src/setup.rs | 10 ++- proxmox-tui-installer/src/views/bootdisk.rs | 74 +++++++++++++------- 4 files changed, 95 insertions(+), 98 deletions(-) -- 2.41.0