From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 57F3291B52 for ; Wed, 4 Oct 2023 16:42:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3412AF446 for ; Wed, 4 Oct 2023 16:42:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 4 Oct 2023 16:42:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4117344866 for ; Wed, 4 Oct 2023 16:42:41 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Wed, 4 Oct 2023 16:42:15 +0200 Message-ID: <20231004144232.327071-5-c.heiss@proxmox.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231004144232.327071-1-c.heiss@proxmox.com> References: <20231004144232.327071-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH installer 4/7] tui: add min/max constraints for ZFS bootdisk parameters X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Oct 2023 14:42:44 -0000 Signed-off-by: Christoph Heiss --- proxmox-tui-installer/src/views/bootdisk.rs | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/proxmox-tui-installer/src/views/bootdisk.rs b/proxmox-tui-installer/src/views/bootdisk.rs index 46bdd9f..8b5b5d2 100644 --- a/proxmox-tui-installer/src/views/bootdisk.rs +++ b/proxmox-tui-installer/src/views/bootdisk.rs @@ -20,6 +20,9 @@ use crate::{ }; use crate::{setup::ProxmoxProduct, InstallerState}; +// See Proxmox::Sys::Block::partition_bootable_disk() +const MINIMUM_DISK_SIZE: f64 = 2.; + pub struct BootdiskOptionsView { view: LinearLayout, advanced_options: Rc>, @@ -501,7 +504,10 @@ impl ZfsBootdiskOptionsView { // TODO: Re-apply previous disk selection from `options` correctly fn new(disks: &[Disk], options: &ZfsBootdiskOptions) -> Self { let inner = FormView::new() - .child("ashift", IntegerEditView::new().content(options.ashift)) + .child( + "ashift", + IntegerEditView::with_range(9, 13).content(options.ashift), + ) .child( "compress", SelectView::new() @@ -526,8 +532,15 @@ impl ZfsBootdiskOptionsView { .unwrap_or_default(), ), ) - .child("copies", IntegerEditView::new().content(options.copies)) - .child("hdsize", DiskSizeEditView::new().content(options.disk_size)); + .child( + "copies", + IntegerEditView::with_range(1, 3).content(options.copies), + ) + .child( + "hdsize", + DiskSizeEditView::with_range(MINIMUM_DISK_SIZE, options.disk_size) + .content(options.disk_size), + ); let view = MultiDiskOptionsView::new(disks, &options.selected_disks, inner) .top_panel(TextView::new( -- 2.42.0