From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <h.laimer@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 4D3F6D6EC
for <pbs-devel@lists.proxmox.com>; Thu, 21 Sep 2023 14:52:15 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 375011FCD2
for <pbs-devel@lists.proxmox.com>; Thu, 21 Sep 2023 14:52:15 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pbs-devel@lists.proxmox.com>; Thu, 21 Sep 2023 14:52:14 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5965E48603
for <pbs-devel@lists.proxmox.com>; Thu, 21 Sep 2023 14:52:14 +0200 (CEST)
From: Hannes Laimer <h.laimer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Date: Thu, 21 Sep 2023 14:51:42 +0200
Message-Id: <20230921125207.1301656-1-h.laimer@proxmox.com>
X-Mailer: git-send-email 2.39.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.018 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pbs-devel] [PATCH proxmox-backup v2 00/25] add removable datastores
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 21 Sep 2023 12:52:15 -0000
These patches add support for removable datastores. All removable
datastores have a backing-device(a UUID) associated with them. Removable
datastores work like normal ones, just that they can be unplugged. It is
possible to create a removable datastore, sync backups onto it, unplug
it and use it on a different PBS.
The datastore path is also the mountpoint for the removable datastore.
By default when creating one through the web UI it will be
`/mnt/removable-datastores/<UUID>`, using the CLI it is possible to
specify something else. Since a removable datastore is associated with
the UUID of a partition, it is technically possible to have two
removable datastores on the same device, but I don't think there is a
use-case that couldn't also be done using namespaces.
When a removable datastore is deleted and 'destroy-data' is set, the
device has to be plugged in. If 'destroy-data' is not set the datastore
can be deleted even if the device is not present. Removable datastores
are automatically mounted when plugged in. At the API service start all
removable datastores are marked as 'unplugged', unless they are already
mounted.
Patches 16/25 and 18/25 are not strictly needed, but they made sense in
this context, so I kept them in this series.
thanks @Lukas and @Thomas for the feedback
v2:
* fix datastore 'add' button in the UI
* some format!("{}", a) -> format!("{a}")
* replace `const` with `let` in js code
* change icon `fa-usb` -> `fa-plug`
* add some docs
* add JDoc for parseMaintenanceMode
* proxmox-schema dep bump
Hannes Laimer (25):
tools: add disks utility functions
pbs-api-types: add backing-device to DataStoreConfig
maintenance: add 'Unpplugged' maintenance type
disks: add UUID to partition info
api2: admin: add (un)mount endpoint for removable datastores
add helper for checking if a removable datastore is available
api2: removable datastore creation
ui: add partition selector form
api2: disks list: add only-unused flag
ui: add removable datastore creation support
ui: add (un)mount button to summary
pbs-api-types: datastore: use new proxmox_scheme::de for
deserialization
pbs-api-types: add removable/is-available flag to DataStoreListItem
ui: display removable datastores in list
ui: utils: render unplugged maintenance mode correctly
ui: utils: make parseMaintenanceMode more robust
ui: add datastore status mask for unplugged removable datastores
ui: maintenance: fix disable msg field if no type is selected
ui: maintenance: disable edit if unplugged
pb-manager: add (un)mount command
add auto-mounting for removable datastores
api: mark removable datastores as unplugged after restart
datastore: handle deletion of removable datastore properly
docs: mention maintenance mode reset when removable datastore is
unplugged
bump proxmox-schema dependency to 2.0.1
Cargo.toml | 2 +-
debian/control | 4 +-
debian/proxmox-backup-server.install | 1 +
debian/proxmox-backup-server.udev | 3 +
docs/maintenance.rst | 2 +
etc/Makefile | 3 +-
etc/removable-device-attach@.service.in | 8 +
pbs-api-types/src/datastore.rs | 40 ++++-
pbs-api-types/src/maintenance.rs | 35 +++-
pbs-datastore/src/datastore.rs | 28 +++-
pbs-datastore/src/lib.rs | 2 +-
src/api2/admin/datastore.rs | 175 +++++++++++++++++++-
src/api2/config/datastore.rs | 67 +++++++-
src/api2/node/disks/mod.rs | 8 +
src/api2/status.rs | 18 +-
src/bin/proxmox-backup-api.rs | 18 ++
src/bin/proxmox_backup_manager/datastore.rs | 60 ++++++-
src/tools/disks/mod.rs | 96 +++++++++--
www/Makefile | 1 +
www/NavigationTree.js | 10 +-
www/Utils.js | 31 +++-
www/css/ext6-pbs.css | 20 +++
www/datastore/DataStoreListSummary.js | 1 +
www/datastore/Summary.js | 108 ++++++++++--
www/form/PartitionSelector.js | 59 +++++++
www/window/DataStoreEdit.js | 50 ++++++
www/window/MaintenanceOptions.js | 16 +-
27 files changed, 803 insertions(+), 63 deletions(-)
create mode 100644 etc/removable-device-attach@.service.in
create mode 100644 www/form/PartitionSelector.js
--
2.39.2