From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <l.wagner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 661FAC9DF
for <pve-devel@lists.proxmox.com>; Mon, 18 Sep 2023 13:14:54 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 455321EC39
for <pve-devel@lists.proxmox.com>; Mon, 18 Sep 2023 13:14:54 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Mon, 18 Sep 2023 13:14:52 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7903E47E9D
for <pve-devel@lists.proxmox.com>; Mon, 18 Sep 2023 13:14:52 +0200 (CEST)
From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Mon, 18 Sep 2023 13:14:36 +0200
Message-Id: <20230918111443.465970-1-l.wagner@proxmox.com>
X-Mailer: git-send-email 2.39.2
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.033 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH v3 many 0/7] notifications: add SMTP endpoint
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 18 Sep 2023 11:14:54 -0000
This patch series adds support for a new notification endpoint type,
smtp. As the name suggests, this new endpoint allows PVE to talk
to SMTP server directly, without using the system's MTA (postfix).
On the Rust side, these patches add a new dependency to the `lettre`
crate for SMTP communication. This crate was chosen as it is:
- by far the most popular mailing crate for Rust
- well maintained
- has reasonable dependencies
- has async support, enabling us to asyncify the proxmox-notify
crate at some point, if needed
These patches are based on top of the `system mail` patch series [1].
>From [1], we need the patches for `proxmox` and `proxmox-perl-rs`.
If `pve-docs` from [1] is not applied first, there might be a small conflict,
however that one should be trivial to resolve.
Tested against
- the gmail SMTP server
- the posteo SMTP server
- our own webmail SMTP server
Changes since v2:
- Rebased proxmox-widget-toolkit onto the latest master to avoid
any conflicts.
Changes since v1:
- Rebased on top of [1]
- Added a mechanism for mails forwarded by `proxmox-mail-forward`
These are forwarded inline as "message/rfc822" to avoid having
to rewrite mail headers (otherwise, some SMTP relays might reject the
mail, because the `From` header of the forwarded mail does not match the
mail account)
[1] https://lists.proxmox.com/pipermail/pve-devel/2023-August/058956.html
proxmox:
Lukas Wagner (3):
notify: fix typo in doc comments
notify: add 'smtp' endpoint
notify: add api for smtp endpoints
Cargo.toml | 1 +
proxmox-notify/Cargo.toml | 4 +-
proxmox-notify/src/api/mod.rs | 48 +++
proxmox-notify/src/api/smtp.rs | 373 ++++++++++++++++++++
proxmox-notify/src/config.rs | 23 ++
proxmox-notify/src/endpoints/common/mail.rs | 24 ++
proxmox-notify/src/endpoints/common/mod.rs | 2 +
proxmox-notify/src/endpoints/mod.rs | 4 +
proxmox-notify/src/endpoints/sendmail.rs | 22 +-
proxmox-notify/src/endpoints/smtp.rs | 260 ++++++++++++++
proxmox-notify/src/lib.rs | 19 +-
11 files changed, 761 insertions(+), 19 deletions(-)
create mode 100644 proxmox-notify/src/api/smtp.rs
create mode 100644 proxmox-notify/src/endpoints/common/mail.rs
create mode 100644 proxmox-notify/src/endpoints/common/mod.rs
create mode 100644 proxmox-notify/src/endpoints/smtp.rs
proxmox-perl-rs:
Lukas Wagner (1):
notify: add bindings for smtp API calls
common/src/notify.rs | 110 +++++++++++++++++++++++++++++++++++++++++++
1 file changed, 110 insertions(+)
pve-manager:
Lukas Wagner (1):
notify: add API routes for smtp endpoints
PVE/API2/Cluster/Notifications.pm | 337 ++++++++++++++++++++++++++++++
1 file changed, 337 insertions(+)
proxmox-widget-toolkit:
Lukas Wagner (1):
panel: notification: add gui for SMTP endpoints
src/Makefile | 2 +
src/Schema.js | 5 +
src/panel/EmailRecipientPanel.js | 89 ++++++++++++++
src/panel/SendmailEditPanel.js | 67 ++---------
src/panel/SmtpEditPanel.js | 192 +++++++++++++++++++++++++++++++
5 files changed, 296 insertions(+), 59 deletions(-)
create mode 100644 src/panel/EmailRecipientPanel.js
create mode 100644 src/panel/SmtpEditPanel.js
pve-docs:
Lukas Wagner (1):
notifications: document SMTP endpoints
notifications.adoc | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
Summary over all repositories:
19 files changed, 1532 insertions(+), 78 deletions(-)
--
murpp v0.4.0