From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <l.wagner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 6F3B7C9B7
for <pve-devel@lists.proxmox.com>; Mon, 18 Sep 2023 10:20:34 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 57E081D1AE
for <pve-devel@lists.proxmox.com>; Mon, 18 Sep 2023 10:20:34 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Mon, 18 Sep 2023 10:20:33 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DD61247DEC
for <pve-devel@lists.proxmox.com>; Mon, 18 Sep 2023 10:20:32 +0200 (CEST)
From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Mon, 18 Sep 2023 10:20:26 +0200
Message-Id: <20230918082026.160163-1-l.wagner@proxmox.com>
X-Mailer: git-send-email 2.39.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.033 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH manager] ui: notification: remove unneeded
gettext calls
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 18 Sep 2023 08:20:34 -0000
'mail-to-root' is the name of the default notification target and
should thus not be translated.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
www/manager6/dc/NotificationEvents.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/dc/NotificationEvents.js b/www/manager6/dc/NotificationEvents.js
index 21628204..18816290 100644
--- a/www/manager6/dc/NotificationEvents.js
+++ b/www/manager6/dc/NotificationEvents.js
@@ -40,7 +40,7 @@ Ext.define('PVE.dc.NotificationEventsTargetSelector', {
editable: true,
autoSelect: false,
deleteEmpty: false,
- emptyText: `${Proxmox.Utils.defaultText} (${gettext("mail-to-root")})`,
+ emptyText: `${Proxmox.Utils.defaultText} (mail-to-root)`,
});
Ext.define('PVE.dc.NotificationEvents', {
@@ -126,7 +126,7 @@ Ext.define('PVE.dc.NotificationEvents', {
// Needed since the actual value is always stored in the 'notify' property
let render_value = (store, target_key, mode_key, default_val) => {
let value = store.getById('notify')?.get('value') ?? {};
- let target = value[target_key] ?? gettext('mail-to-root');
+ let target = value[target_key] ?? 'mail-to-root';
let template;
switch (value[mode_key]) {
--
2.39.2