From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <a.zeidler@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 36E69B950
 for <pve-devel@lists.proxmox.com>; Tue, 12 Sep 2023 16:39:13 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 194C1145DC
 for <pve-devel@lists.proxmox.com>; Tue, 12 Sep 2023 16:39:13 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pve-devel@lists.proxmox.com>; Tue, 12 Sep 2023 16:39:12 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EBABA46018
 for <pve-devel@lists.proxmox.com>; Tue, 12 Sep 2023 16:39:11 +0200 (CEST)
From: Alexander Zeidler <a.zeidler@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Tue, 12 Sep 2023 16:38:48 +0200
Message-Id: <20230912143848.145161-1-a.zeidler@proxmox.com>
X-Mailer: git-send-email 2.39.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -1.004 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URI_TRY_3LD             1.999 "Try it" URI, suspicious hostname
Subject: [pve-devel] [PATCH manager] ui: vm create wizard: default to 2
 cores for win 11 os type
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 12 Sep 2023 14:39:13 -0000

Windows 11 installer requires 2 cores [0]. Tested with Win11_22H2_English_x64v2.iso from [1].

Windows Server 2022 installer still requires only 1 core [2]. Tested with SERVER_EVAL_x64FRE_en-us.iso from [3].

[0] https://support.microsoft.com/en-us/windows/windows-11-system-requirements-86c11283-ea52-4782-9efd-7674389a7ba3
[1] https://www.microsoft.com/software-download/windows11
[2] https://learn.microsoft.com/en-us/windows-server/get-started/hardware-requirements
[3] https://www.microsoft.com/en-us/evalcenter/download-windows-server-2022

Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
---
 www/manager6/qemu/ProcessorEdit.js | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/www/manager6/qemu/ProcessorEdit.js b/www/manager6/qemu/ProcessorEdit.js
index b845ff66..7651dcd3 100644
--- a/www/manager6/qemu/ProcessorEdit.js
+++ b/www/manager6/qemu/ProcessorEdit.js
@@ -23,12 +23,27 @@ Ext.define('PVE.qemu.ProcessorInputPanel', {
 
     controller: {
 	xclass: 'Ext.app.ViewController',
+	control: {
+            '#': {
+                afterrender: 'setProcessor',
+            },
+        },
 	init: function() {
 	    let me = this;
 	    let viewModel = me.getViewModel();
 
 	    viewModel.set('userIsRoot', Proxmox.UserName === 'root@pam');
 	},
+	setProcessor: function() {
+	    let me = this;
+	    let view = me.getView(), vm = me.getViewModel();
+	    if (view.insideWizard) {
+		let ostype = vm.get('current.ostype');
+		if (ostype === 'win11') {
+		    me.lookup('cores').setValue('2');
+		}
+	    }
+	},
     },
 
     onGetValues: function(values) {
@@ -123,6 +138,7 @@ Ext.define('PVE.qemu.ProcessorInputPanel', {
 	},
 	{
 	    xtype: 'proxmoxintegerfield',
+	    reference: 'cores',
 	    name: 'cores',
 	    minValue: 1,
 	    maxValue: 128,
-- 
2.39.2