From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <f.ebner@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3ABD59631 for <pve-devel@lists.proxmox.com>; Mon, 4 Sep 2023 13:39:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1C437E2E2 for <pve-devel@lists.proxmox.com>; Mon, 4 Sep 2023 13:39:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Mon, 4 Sep 2023 13:39:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 36B424102A for <pve-devel@lists.proxmox.com>; Mon, 4 Sep 2023 13:39:56 +0200 (CEST) From: Fiona Ebner <f.ebner@proxmox.com> To: pve-devel@lists.proxmox.com Date: Mon, 4 Sep 2023 13:39:44 +0200 Message-Id: <20230904113949.940431-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.079 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH-SERIES qemu-server] avoid cyclic use of main module in memory module X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 04 Sep 2023 11:39:59 -0000 Mostly cleanup, moving some code out of the main module and as indirect preparation for Alexandre's series reworking memory hotplug [0]. At one point during development, the cyclic use caused actual problems [1]. Let's avoid any future surprises caused by the cyclic use and get rid of it. Also includes the first patch of Alexandre's series, because that gets rid of the PVE::QemuServer::defaults() call. Because of that patch a versioned Breaks for pve-ha-manager < 4.0.1 is needed, because earlier versions don't expect a property string. [0]: https://lists.proxmox.com/pipermail/pve-devel/2023-June/057690.html [1]: https://lists.proxmox.com/pipermail/pve-devel/2023-January/055356.html Alexandre Derumier (1): add memory parser Fiona Ebner (4): move parse_number_sets() helper to helpers module move NUMA-related code into memory module memory: replace deprecated check_running() call introduce QMPHelpers module PVE/API2/Qemu.pm | 7 +- PVE/QemuConfig.pm | 8 +- PVE/QemuMigrate.pm | 6 +- PVE/QemuServer.pm | 123 +++++-------------------------- PVE/QemuServer/Helpers.pm | 18 ++++- PVE/QemuServer/Makefile | 1 + PVE/QemuServer/Memory.pm | 138 +++++++++++++++++++++++++++++------ PVE/QemuServer/QMPHelpers.pm | 48 ++++++++++++ 8 files changed, 208 insertions(+), 141 deletions(-) create mode 100644 PVE/QemuServer/QMPHelpers.pm -- 2.39.2