From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BA7EE8269 for ; Wed, 30 Aug 2023 13:57:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A2D5B342A0 for ; Wed, 30 Aug 2023 13:57:50 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 30 Aug 2023 13:57:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 391A64776A for ; Wed, 30 Aug 2023 13:57:48 +0200 (CEST) From: Filip Schauer To: pve-devel@lists.proxmox.com Date: Wed, 30 Aug 2023 13:57:44 +0200 Message-Id: <20230830115744.79622-1-f.schauer@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 widget-toolkit] fix #4531: Fix ACME plugin edit form not detecting changes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Aug 2023 11:57:50 -0000 Fix the ACME plugin edit form only detecting dirtychanges once the value of a textfield was dirtied and then changed back to the original. This behaviour is caused by setting the originalValue directly without calling checkDirty. The reason is that the dirty flag of the textfield is set to true by setValue, and then not reset to false even though the value matches the original value. This is fixed by calling checkDirty after setting the originalValue to refresh the dirty flag. Signed-off-by: Filip Schauer --- Changes since v1: * Fix introduced bug that would set a dirty value as the original one when switching plugins. * Improve the commit message src/window/ACMEPluginEdit.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/window/ACMEPluginEdit.js b/src/window/ACMEPluginEdit.js index 0f21527..66ef02c 100644 --- a/src/window/ACMEPluginEdit.js +++ b/src/window/ACMEPluginEdit.js @@ -127,6 +127,7 @@ Ext.define('Proxmox.window.ACMEPluginEdit', { if (me.createdFields[key]) { me.createdFields[key].setValue(value); me.createdFields[key].originalValue = me.originalValues[key]; + me.createdFields[key].checkDirty(); } else { extradata.push(`${key}=${value}`); } -- 2.39.2