From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <l.wagner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id CCF259D29
 for <pve-devel@lists.proxmox.com>; Mon, 28 Aug 2023 14:58:50 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id B57281D649
 for <pve-devel@lists.proxmox.com>; Mon, 28 Aug 2023 14:58:50 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pve-devel@lists.proxmox.com>; Mon, 28 Aug 2023 14:58:50 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D39A647136
 for <pve-devel@lists.proxmox.com>; Mon, 28 Aug 2023 14:58:49 +0200 (CEST)
From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Mon, 28 Aug 2023 14:58:34 +0200
Message-Id: <20230828125834.496905-1-l.wagner@proxmox.com>
X-Mailer: git-send-email 2.39.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.037 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH manager] notify ui: fix `gettext` calls
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 28 Aug 2023 12:58:50 -0000

gettext is rather dumb and does not like multi-line strings or string
interpolation.

Also removed some unneeded gettext calls (mail-to-root should not be
translated.)

Reported-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 www/manager6/dc/NotificationEvents.js | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/www/manager6/dc/NotificationEvents.js b/www/manager6/dc/NotificationEvents.js
index f2ee12e0..18816290 100644
--- a/www/manager6/dc/NotificationEvents.js
+++ b/www/manager6/dc/NotificationEvents.js
@@ -29,8 +29,7 @@ Ext.define('PVE.dc.NotificationEventDisabledWarning', {
     extend: 'Ext.form.field.Display',
     userCls: 'pmx-hint',
     hidden: true,
-    value: gettext('Disabling notifications is not ' +
-        'recommended for production systems!'),
+    value: gettext('Disabling notifications is not recommended for production systems!'),
 });
 
 Ext.define('PVE.dc.NotificationEventsTargetSelector', {
@@ -41,7 +40,7 @@ Ext.define('PVE.dc.NotificationEventsTargetSelector', {
     editable: true,
     autoSelect: false,
     deleteEmpty: false,
-    emptyText: `${Proxmox.Utils.defaultText} (${gettext("mail-to-root")})`,
+    emptyText: `${Proxmox.Utils.defaultText} (mail-to-root)`,
 });
 
 Ext.define('PVE.dc.NotificationEvents', {
@@ -127,7 +126,7 @@ Ext.define('PVE.dc.NotificationEvents', {
 	// Needed since the actual value is always stored in the 'notify' property
 	let render_value = (store, target_key, mode_key, default_val) => {
 	    let value = store.getById('notify')?.get('value') ?? {};
-	    let target = value[target_key] ?? gettext('mail-to-root');
+	    let target = value[target_key] ?? 'mail-to-root';
 	    let template;
 
 	    switch (value[mode_key]) {
-- 
2.39.2