From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B809F8F89 for <pbs-devel@lists.proxmox.com>; Tue, 1 Aug 2023 11:29:55 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 98982C3E7 for <pbs-devel@lists.proxmox.com>; Tue, 1 Aug 2023 11:29:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pbs-devel@lists.proxmox.com>; Tue, 1 Aug 2023 11:29:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EE70F4393A for <pbs-devel@lists.proxmox.com>; Tue, 1 Aug 2023 11:29:54 +0200 (CEST) From: Dominik Csapak <d.csapak@proxmox.com> To: pbs-devel@lists.proxmox.com Date: Tue, 1 Aug 2023 11:29:51 +0200 Message-Id: <20230801092954.1686860-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs, environment.rs] Subject: [pbs-devel] [RFC PATCH proxmox-backup 0/3] show upload statistics in gui X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 01 Aug 2023 09:29:55 -0000 Sending as RFC because: * not sure if we want to increase the size of the 'list snapshots' api call even further (albeit by a small amount per snapshot that we already have anyway in memory) * not sure if we want to have another action in the gui alternatively we could: * add a seperate api call to get detailed info about a snapshot (incl the upload statistics) * add the info as a tooltip to the 'size' column (or somewhere else?) i just fear that this is too subtle for most people to notice Dominik Csapak (3): api-types: make UploadStatistic an api type api: datastore: add upload_statistic to snapshot listing ui: datastore content: add action to show upload statistics pbs-api-types/src/datastore.rs | 41 +++++++++++++++++++++++++ src/api2/admin/datastore.rs | 22 ++++++++++--- src/api2/backup/environment.rs | 35 +-------------------- www/datastore/Content.js | 56 ++++++++++++++++++++++++++++++++++ 4 files changed, 115 insertions(+), 39 deletions(-) -- 2.30.2