From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <a.zeidler@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 249DD8961 for <pve-devel@lists.proxmox.com>; Fri, 28 Jul 2023 15:29:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 046C015F5B for <pve-devel@lists.proxmox.com>; Fri, 28 Jul 2023 15:29:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Fri, 28 Jul 2023 15:29:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1172D41F11 for <pve-devel@lists.proxmox.com>; Fri, 28 Jul 2023 15:29:06 +0200 (CEST) From: Alexander Zeidler <a.zeidler@proxmox.com> To: pve-devel@lists.proxmox.com Date: Fri, 28 Jul 2023 15:28:54 +0200 Message-Id: <20230728132858.98806-1-a.zeidler@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v4 manager/container/guest-common/docs 0/4] fix #3069: add pbs-entries-max to vzdump.conf X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 28 Jul 2023 13:29:07 -0000 Users reported[1] about failing container backups to PBS when having a large amount of files in a directory. proxmox-backup-client has already 'entries-max' implemented. The default value prevents out of memory (OOM) situations. Overriding this parameter needs at least 'Sys.Modify' permissions. This patch series makes the new optional performance parameter 'pbs-entries-max' available in vzdump and vzdump.conf. [1] https://bugzilla.proxmox.com/show_bug.cgi?id=3069 Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com> --- Changes since v3: * apply Fiona's comments. For details see patch emails. Changes since v2: * apply Fiona's comments. For details see patch emails. * add new commit (pve-docs) * update coverletter text Changes since v1: * apply Fiona's comments. For details see patch emails. pve-manager: Alexander Zeidler (1): fix #3069: vzdump: add property 'performance: pbs-entries-max=N' configs/vzdump.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) pve-container: Alexander Zeidler (1): fix #3069: vzdump: add 'pbs-entries-max' parameter src/PVE/VZDump/LXC.pm | 6 ++++++ 1 file changed, 6 insertions(+) pve-guest-common: Alexander Zeidler (1): fix #3069: vzdump: schema: add 'pbs-entries-max' property src/PVE/VZDump/Common.pm | 9 +++++++++ 1 file changed, 9 insertions(+) pve-docs: Alexander Zeidler (1): vzdump: mention new parameter 'pbs-entries-max' vzdump.adoc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.39.2