From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <c.heiss@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 71FDBFA5A for <pve-devel@lists.proxmox.com>; Mon, 24 Jul 2023 12:15:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 57737C9C3 for <pve-devel@lists.proxmox.com>; Mon, 24 Jul 2023 12:15:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Mon, 24 Jul 2023 12:15:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4730743AC4 for <pve-devel@lists.proxmox.com>; Mon, 24 Jul 2023 12:15:28 +0200 (CEST) From: Christoph Heiss <c.heiss@proxmox.com> To: pve-devel@lists.proxmox.com Date: Mon, 24 Jul 2023 12:14:44 +0200 Message-ID: <20230724101517.462214-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.052 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH installer v2 0/6] tui: add ZFS/Btrfs RAID setup checks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 24 Jul 2023 10:15:59 -0000 This introduces the same checks when creating a RAID setup for ZFS and Btrfs as in the GUI installer. The main benefit is that the user now gets an error before the setup dialog can even be closed, instead of during the install process. Patch #1 is just some cleanup I noticed along the way, #2 and #3 are preparatory patches. #4 then implements the actual functionality and #5 unit tests for all that. #6 just enables dh_auto_test in the end. Notable changes v1 -> v2: * Rebased series on latest master * Added patch #6, enabling dh_auto_test v1: https://lists.proxmox.com/pipermail/pve-devel/2023-July/058077.html pve-installer: Christoph Heiss (6): tui: simplify duplicate disk checking logic tui: deserialize boot type and disk blocksize from runtime env info tui: improve bootdisk dialog error handling tui: add RAID setup checks for ZFS/Btrfs tui: add tests for RAID setup checks d/rules: enable dh_auto_test Makefile | 3 + debian/rules | 3 - proxmox-tui-installer/src/options.rs | 1 + proxmox-tui-installer/src/setup.rs | 15 +- proxmox-tui-installer/src/views/bootdisk.rs | 368 ++++++++++++++++++-- 5 files changed, 349 insertions(+), 41 deletions(-) -- 2.41.0