From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 288AD90B5 for <pmg-devel@lists.proxmox.com>; Fri, 23 Jun 2023 14:21:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0B5573476D for <pmg-devel@lists.proxmox.com>; Fri, 23 Jun 2023 14:21:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pmg-devel@lists.proxmox.com>; Fri, 23 Jun 2023 14:21:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1A09E42FFC for <pmg-devel@lists.proxmox.com>; Fri, 23 Jun 2023 14:21:08 +0200 (CEST) From: Dominik Csapak <d.csapak@proxmox.com> To: pmg-devel@lists.proxmox.com Date: Fri, 23 Jun 2023 14:20:59 +0200 Message-Id: <20230623122104.2411099-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [dbtools.pm, config.pm] Subject: [pmg-devel] [PATCH pmg-api/gui] perparations and breaking changes X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion <pmg-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/> List-Post: <mailto:pmg-devel@lists.proxmox.com> List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 23 Jun 2023 12:21:39 -0000 in bookworm, postgres15 has more restrictive permissions, so we have to adapt to that in addition, we want to disable some options by default, namely: advfiler (advances statistic filters) use_bayes use_awl (auto-whitelist) these patches simply change default in the config & frontent, so these are breaking changes. To deal with that we have (at least) these three possibilities: * simply document them in the upgrade guide easiest for us, but has *some* potential for issues when users don't properly read/follow them and their bayes/awl db get's deleted * use preinst/postinst script to set the old defaults as explicit values in the config. this shouldn't be too hard, but is some baggage that we have to keep until the next major version * introduce a pmg7to8 tool like for pve it's the most work, but we could potentiall use this also for detecting misconfigurations, add warnings e.g. about templates, not running postgres instances (or still running old instances after the upgrade), not current packages, etc. pmg-api: Dominik Csapak (3): dbtools: grant permissions public schema for created databases config: disable awl and bayes by default config: disable advanced statistic filters by default src/PMG/Config.pm | 6 +++--- src/PMG/DBTools.pm | 8 ++++++++ 2 files changed, 11 insertions(+), 3 deletions(-) pmg-gui: Dominik Csapak (2): configuration: options: adapt to new advanced statistic filter default spam: options: adapt do new defaults for bayes/awl js/SpamDetectorOptions.js | 4 ++-- js/SystemOptions.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.30.2