From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <m.sandoval@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 6137AA2AA2
for <pve-devel@lists.proxmox.com>; Tue, 20 Jun 2023 11:16:44 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 4711C32676
for <pve-devel@lists.proxmox.com>; Tue, 20 Jun 2023 11:16:14 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Tue, 20 Jun 2023 11:16:13 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2EFC1409AA
for <pve-devel@lists.proxmox.com>; Tue, 20 Jun 2023 11:16:12 +0200 (CEST)
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Tue, 20 Jun 2023 11:16:10 +0200
Message-Id: <20230620091610.68835-8-m.sandoval@proxmox.com>
X-Mailer: git-send-email 2.39.2
In-Reply-To: <20230620091610.68835-1-m.sandoval@proxmox.com>
References: <20230620091610.68835-1-m.sandoval@proxmox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.000 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: [pve-devel] [PATCH installer 7/7] remove trailing spaces and colons
from labels
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 20 Jun 2023 09:16:44 -0000
For consistency sake, all colons and trailing spaces in labels were
removed, this matches other panels such as the password and
country/timezone panels.
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
proxinstall | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/proxinstall b/proxinstall
index 86922e2..b2c214b 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1559,7 +1559,7 @@ sub create_ipconf_view {
}
my $devicebox = Gtk3::Box->new('horizontal', 0);
- my $label = Gtk3::Label->new("Management Interface:");
+ my $label = Gtk3::Label->new("Management Interface");
$label->set_size_request(150, -1);
$label->set_xalign(1.0);
@@ -1569,7 +1569,7 @@ sub create_ipconf_view {
my $fqdn = Proxmox::Install::Config::get_fqdn();
my $hn = $fqdn // "$iso_env->{product}." . ($ipconf->{domain} // "example.invalid");
- my ($hostlabel, $hostentry) = create_text_input($hn, 'Hostname (FQDN):');
+ my ($hostlabel, $hostentry) = create_text_input($hn, 'Hostname (FQDN)');
$grid->attach($hostlabel, 0, 1, 1, 1);
$grid->attach($hostentry, 1, 1, 1, 1);
@@ -1580,7 +1580,7 @@ sub create_ipconf_view {
my $gwlabel;
($gwlabel, $ipconf_entry_gw) =
- create_text_input($gateway, 'Gateway:');
+ create_text_input($gateway, 'Gateway');
$grid->attach($gwlabel, 0, 3, 1, 1);
$grid->attach($ipconf_entry_gw, 1, 3, 1, 1);
@@ -1589,7 +1589,7 @@ sub create_ipconf_view {
my $dns_label;
($dns_label, $ipconf_entry_dns) =
- create_text_input($dnsserver, 'DNS Server:');
+ create_text_input($dnsserver, 'DNS Server');
$grid->attach($dns_label, 0, 4, 1, 1);
$grid->attach($ipconf_entry_dns, 1, 4, 1, 1);
@@ -2452,7 +2452,7 @@ sub create_hdoption_view {
$target_hd_label->set_text("Target: $filesys ");
$options_stack->set_visible_child_name("raiddisk");
} else {
- $target_hd_label->set_text("Target Harddisk: ");
+ $target_hd_label->set_text("Target Harddisk");
}
if ($raid) {
@@ -2665,7 +2665,7 @@ sub create_hdsel_view {
my ($disk, $devname, $size, $model, $logical_bsize) = $cached_disks->[0]->@*;
$target_hd = $devname if !defined($target_hd);
- $target_hd_label = Gtk3::Label->new("Target Harddisk: ");
+ $target_hd_label = Gtk3::Label->new("Target Harddisk");
$hbox->pack_start($target_hd_label, 0, 0, 0);
$target_hd_combo = Gtk3::ComboBoxText->new();
--
2.39.2