From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <root@kvmformation3.odiso.net> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 83615A25A4 for <pve-devel@lists.proxmox.com>; Mon, 19 Jun 2023 09:29:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5DA1D252DC for <pve-devel@lists.proxmox.com>; Mon, 19 Jun 2023 09:28:54 +0200 (CEST) Received: from bastionodiso.odiso.net (bastionodiso.odiso.net [IPv6:2a0a:1580:2000::2d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Mon, 19 Jun 2023 09:28:53 +0200 (CEST) Received: from kvmformation3.odiso.net (formationkvm3.odiso.net [10.3.94.12]) by bastionodiso.odiso.net (Postfix) with ESMTP id 3A04D8002; Mon, 19 Jun 2023 09:28:45 +0200 (CEST) Received: by kvmformation3.odiso.net (Postfix, from userid 0) id 244AE241499; Mon, 19 Jun 2023 09:28:45 +0200 (CEST) From: Alexandre Derumier <aderumier@odiso.com> To: pve-devel@lists.proxmox.com Date: Mon, 19 Jun 2023 09:28:29 +0200 Message-Id: <20230619072841.38531-1-aderumier@odiso.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy HEADER_FROM_DIFFERENT_DOMAINS 0.25 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH-SERIE v6 qemu-server/pve-manager] rework memory hotplug + virtiomem X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 19 Jun 2023 07:29:24 -0000 This patch series rework the current memory hotplug + virtiomem. memory option now have extra options: memory: [[current=]<integer>] [,max=<enum>] [,virtio=<1|0>] ex: memory: current=1024,max=131072,virtio=1 for classic memory hotplug, when maxmemory is defined, we use 64 fixed size dimm. The max option is a multiple of 64GB. The virtio option enable new virtio-mem support, instead of plugging dimm, it's add/removed block inside big dimm. virtio-mem can use 32000 blocks, the blocksize is compute from max memory. Changelog v2: update differents patches based on Fiona comments. (I have send 2 others mails with comments not yet addressed) Biggest change is on virtio-mem, instead of trying to have same amount of memory on each virtiomem (some block could be unmovable and break unplug), we try to balance/dispatch remaining block on other available virtiomems. Also, the minimum blocksize supported by linux guest os is 4MB currently, even if virtiomem can use 2MB on qemu side. Changelog v3: - cleanup from last Fiona comments - classic hotplug : fix memory unplug - virtio-mem: split retry logic in a second optional patch (feel free to apply it later if needed) Changelog v4: - cleanup from last Fiona comments Changelog v5: - move dimm hot-unplug patches on top of the serie - cleanup from last Fiona comments Changelog v6: - qemu-server : rebase on last git qemu-server: Alexandre Derumier (10): add memory parser memory: add get_static_mem memory: use static_memory in foreach_dimm config: memory: add 'max' option memory: get_max_mem: use config memory max memory: use 64 slots && static dimm size when max is defined test: add memory-max tests memory: add virtio-mem support memory: virtio-mem : implement redispatch retry. tests: add virtio-mem tests PVE/API2/Qemu.pm | 41 +- PVE/QemuConfig.pm | 4 +- PVE/QemuMigrate.pm | 6 +- PVE/QemuServer.pm | 37 +- PVE/QemuServer/Helpers.pm | 3 +- PVE/QemuServer/Memory.pm | 422 +++++++++++++++--- PVE/QemuServer/PCI.pm | 8 + test/cfg2cmd/memory-max-128G.conf | 11 + test/cfg2cmd/memory-max-128G.conf.cmd | 86 ++++ test/cfg2cmd/memory-max-512G.conf | 11 + test/cfg2cmd/memory-max-512G.conf.cmd | 58 +++ test/cfg2cmd/memory-virtio-hugepages-1G.conf | 12 + .../memory-virtio-hugepages-1G.conf.cmd | 35 ++ test/cfg2cmd/memory-virtio-max.conf | 11 + test/cfg2cmd/memory-virtio-max.conf.cmd | 35 ++ test/cfg2cmd/memory-virtio.conf | 11 + test/cfg2cmd/memory-virtio.conf.cmd | 35 ++ 17 files changed, 744 insertions(+), 82 deletions(-) create mode 100644 test/cfg2cmd/memory-max-128G.conf create mode 100644 test/cfg2cmd/memory-max-128G.conf.cmd create mode 100644 test/cfg2cmd/memory-max-512G.conf create mode 100644 test/cfg2cmd/memory-max-512G.conf.cmd create mode 100644 test/cfg2cmd/memory-virtio-hugepages-1G.conf create mode 100644 test/cfg2cmd/memory-virtio-hugepages-1G.conf.cmd create mode 100644 test/cfg2cmd/memory-virtio-max.conf create mode 100644 test/cfg2cmd/memory-virtio-max.conf.cmd create mode 100644 test/cfg2cmd/memory-virtio.conf create mode 100644 test/cfg2cmd/memory-virtio.conf.cmd pve-manager: Alexandre Derumier (2): ui: qemu: hardware: add new memory format support ui: qemu : memoryedit: add new max && virtio fields www/manager6/qemu/HardwareView.js | 17 ++++++++-- www/manager6/qemu/MemoryEdit.js | 52 +++++++++++++++++++++++++------ 2 files changed, 58 insertions(+), 11 deletions(-) -- 2.39.2