From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <l.wagner@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5ED9096B1B for <pve-devel@lists.proxmox.com>; Thu, 26 Jan 2023 11:47:15 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 37B0B21D2D for <pve-devel@lists.proxmox.com>; Thu, 26 Jan 2023 11:47:15 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Thu, 26 Jan 2023 11:47:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A3B17465B6 for <pve-devel@lists.proxmox.com>; Thu, 26 Jan 2023 11:47:13 +0100 (CET) From: Lukas Wagner <l.wagner@proxmox.com> To: pve-devel@lists.proxmox.com Date: Thu, 26 Jan 2023 11:47:09 +0100 Message-Id: <20230126104711.377316-1-l.wagner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 2.340 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_HI -5 Sender listed at https://www.dnswl.org/, high trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v3 manager/widget-toolkit 0/2] ui: replace non-clickable checkboxes with icons X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 26 Jan 2023 10:47:15 -0000 In our UI, we've been a bit inconsistent with the use of checkboxes/text for `enabled` properties in table views. Looking through the UI, I've found that the following UI elements use a checkbox UI control to indicate wheter something is enabled or not: * backup job overview * APT repository overview * replication job overview While looking sleek, the problem with this is that from a user's perspective, a checkbox generally implies that it is operable by clicking on it (which we allow in other places, to make the matter even more confusing). Now, for the three UI elements mentioned above, I would say it is a good thing that they are not manipulateable from the overview, in order to avoid any accidental modifications. In this patch series, the checkbox is replaced by a checkmark (fa-check) icon if enabled, or by a minus/dash (fa-minus) icon if disabled. Note: Firewall configuration also uses a checkbox, however there it is possible to enable/disable elements by clicking on the checkbox. As mentioned by Thomas in v1, this could be replaced by a more explicit icon-based toggle button in a future series. Changes v2 -> v3: * Fixed typo 'dataindex' -> 'dataIndex' * Use camel case for render function * Use arrow functions * Remove spurious newline proxmox-widget-toolkit: Lukas Wagner (1): repo view: replace non-clickable checkbox with icons src/Utils.js | 2 ++ src/node/APTRepositories.js | 6 ++---- 2 files changed, 4 insertions(+), 4 deletions(-) pve-manager: Lukas Wagner (1): ui: backup: replication: replace non-clickable checkbox with icons www/manager6/dc/Backup.js | 7 +++---- www/manager6/grid/Replication.js | 7 ++++--- 2 files changed, 7 insertions(+), 7 deletions(-) -- 2.30.2