From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <s.ivanov@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 71D89961F0 for <pmg-devel@lists.proxmox.com>; Mon, 23 Jan 2023 16:55:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 51CDA29DC0 for <pmg-devel@lists.proxmox.com>; Mon, 23 Jan 2023 16:55:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pmg-devel@lists.proxmox.com>; Mon, 23 Jan 2023 16:55:51 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1E97A45C74 for <pmg-devel@lists.proxmox.com>; Mon, 23 Jan 2023 16:55:51 +0100 (CET) From: Stoiko Ivanov <s.ivanov@proxmox.com> To: pmg-devel@lists.proxmox.com Date: Mon, 23 Jan 2023 16:55:19 +0100 Message-Id: <20230123155521.28307-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 2.656 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_HI -5 Sender listed at https://www.dnswl.org/, high trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [postfix.org, quarantine.pm, utils.pm, smtp.pm, notify.pm] Subject: [pmg-devel] [PATCH pmg-api 0/2] fix smtputf8 handling if disabled in postfix X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion <pmg-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/> List-Post: <mailto:pmg-devel@lists.proxmox.com> List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>, <mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 23 Jan 2023 15:55:53 -0000 This series addresses an issue some of our users reported in our community forum with pmg-api_7.2-3: * the decision if smtputf8 is needed is based on the envelope-addresses and the headers (if they contain non-ascii characters we use SMTPUTF8 * this breaks environments where SMTPUTF8 is disabled (mostly because some downstream servers do not support this), but mails still contain non-ascii data (while this is against the relevant rfc, which say that header-data must contain only ascii characters (and should be encoded with MIME-words otherwise), it is seemingly quite common in the wild) one testmail I got from a user from the forum had the From header correctly encoded, but added an X-DFrom header with the unencoded from. The first patch simply drops the header-inspection and should enable most of the reporters to receive mail again. The second patch tries to address the smtputf8 issue a bit differently than what we currently do - For mails received via SMTP it simply sets SMTPUTF8 if the original postfix processes sent pmg-smtp-filter the mail with the flag, and does not set it otherwise - For locally generated mail it detects if its needed by checking the envelope-addresses and the headers for non-ascii characters. This should follow postfix own functioning quite closely: https://www.postfix.org/SMTPUTF8_README.html processing by pmg-smtp-filter should not change the need for the flag, since we don't rewrite envelope-addresses, and modify filed does mime-encode the resulting header. Sending as two patches, since the first one would be good to get out soon (as it's affecting a few setups), while the second one might benefit from a bit more testing (I did some tests, which all looked good, but might have overlooked some cases) Stoiko Ivanov (2): utils: skip checking headers for non-ascii characters smtputf8: keep smtputf8 from incoming postfix, detect for local mail src/PMG/API2/Quarantine.pm | 7 ++++++- src/PMG/RuleDB/Notify.pm | 6 +++++- src/PMG/SMTP.pm | 7 ++++++- src/PMG/Utils.pm | 12 +++++++++--- 4 files changed, 26 insertions(+), 6 deletions(-) -- 2.30.2