all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Leo Nunner <l.nunner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 storage docs] Allow overrides for default directories
Date: Mon,  2 Jan 2023 17:04:36 +0100	[thread overview]
Message-ID: <20230102160438.180285-1-l.nunner@proxmox.com> (raw)

This patch adds a parameter to the storage configuration that allows the
default directory structure to be overridden. For now, I allowed the
parameter for the directory, CIFS and NFS plugins.

I tested the following things:
    - Create VMs/CTs
    - Upload ISOs/container templates
    - Create/restore backups
    - Upload snippets
    - Move images between storages with different configurations

All of which posed no problems with the UI and were put into the correct
(custom) location. I also did migrations with a few different
configurations, which also worked correctly.

Changes from v1:
    - Change parameter verification from pve-volume-id to a custom
      format that also verifies the validity of the path and the given
      vtype.

storage:

Leo Nunner (1):
  config: add overrides for default directory locations

 PVE/Storage/CIFSPlugin.pm |  1 +
 PVE/Storage/DirPlugin.pm  |  1 +
 PVE/Storage/NFSPlugin.pm  |  1 +
 PVE/Storage/Plugin.pm     | 49 +++++++++++++++++++++++++++++++++++----
 test/get_subdir_test.pm   |  7 ++++++
 5 files changed, 55 insertions(+), 4 deletions(-)

docs:

Leo Nunner (1):
  docs: document 'dirs' parameter for directory storage

 pve-storage-cifs.adoc |  4 ++++
 pve-storage-dir.adoc  | 19 ++++++++++++++-----
 pve-storage-nfs.adoc  |  4 ++++
 3 files changed, 22 insertions(+), 5 deletions(-)

-- 
2.30.2





             reply	other threads:[~2023-01-02 16:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-02 16:04 Leo Nunner [this message]
2023-01-02 16:04 ` [pve-devel] [PATCH v2 storage] config: add overrides for default directory locations Leo Nunner
2023-01-05 13:34   ` [pve-devel] applied: " Wolfgang Bumiller
2023-01-05 13:54   ` [pve-devel] " Thomas Lamprecht
2023-01-02 16:04 ` [pve-devel] [PATCH v2 docs] docs: document 'dirs' parameter for directory storage Leo Nunner
2023-01-05 13:35   ` [pve-devel] applied: " Wolfgang Bumiller
2023-01-05 13:41 ` [pve-devel] [PATCH v2 storage docs] Allow overrides for default directories Wolfgang Bumiller
2023-01-05 13:53   ` Thomas Lamprecht
2023-01-05 14:02     ` Wolfgang Bumiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230102160438.180285-1-l.nunner@proxmox.com \
    --to=l.nunner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal