From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 5C81E1FF13C for ; Thu, 02 Apr 2026 18:50:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 11DC51F8DA; Thu, 2 Apr 2026 18:50:49 +0200 (CEST) Message-ID: <20221d42-9742-496d-aa77-a564c8e72e3e@proxmox.com> Date: Thu, 2 Apr 2026 18:50:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-backup v3 3/3] fix #7400: proxy: self-heal corrupted job statefiles To: =?UTF-8?Q?Michael_K=C3=B6ppl?= , pbs-devel@lists.proxmox.com References: <20260325160617.342295-1-m.koeppl@proxmox.com> <20260325160617.342295-4-m.koeppl@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260325160617.342295-4-m.koeppl@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775148556110 X-SPAM-LEVEL: Spam detection results: 0 AWL -2.431 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_MAILER 2 Automated Mailer Tag Left in Email RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: G6RJVFJAMGTIRTSKTUJ5IXHNQWQGIQOH X-Message-ID-Hash: G6RJVFJAMGTIRTSKTUJ5IXHNQWQGIQOH X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: One nit inline. Other than that: Reviewed-by: Christian Ebner On 3/25/26 5:06 PM, Michael Köppl wrote: > Update update_job_last_run_time to transition JobState::Unknown into > JobState::Created so the corrupted statefile is overwritten. In > addition, update the scheduling loops to actively overwrite corrupted > statefiles and return the time for the next scheduled run of the > affected job. > > Signed-off-by: Michael Köppl > --- > src/bin/proxmox-backup-proxy.rs | 4 +++- > src/server/jobstate.rs | 2 +- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/bin/proxmox-backup-proxy.rs b/src/bin/proxmox-backup-proxy.rs > index c1fe3ac15..71d8566f4 100644 > --- a/src/bin/proxmox-backup-proxy.rs > +++ b/src/bin/proxmox-backup-proxy.rs > @@ -564,6 +564,7 @@ async fn schedule_datastore_garbage_collection() { > Ok(time) => time, > Err(err) => { > eprintln!("could not get last run time of {worker_type} {store}: {err}"); > + let _ = jobstate::update_job_last_run_time(worker_type, &store); > continue; > } > }; > @@ -936,7 +937,8 @@ fn check_schedule(worker_type: &str, event_str: &str, id: &str) -> bool { > Ok(time) => time, > Err(err) => { > eprintln!("could not get last run time of {worker_type} {id}: {err}"); > - return false; > + let _ = jobstate::update_job_last_run_time(worker_type, id); > + proxmox_time::epoch_i64() - 30 nit: Should we define the offset from epoch here as constant? This is used in several places now and having one common constant with a meaningful name would help with code quality IMHO. > } > }; > > diff --git a/src/server/jobstate.rs b/src/server/jobstate.rs > index 4163656e8..214691965 100644 > --- a/src/server/jobstate.rs > +++ b/src/server/jobstate.rs > @@ -156,7 +156,7 @@ pub fn update_job_last_run_time(jobtype: &str, jobname: &str) -> Result<(), Erro > state, > updated: Some(time), > }, > - JobState::Unknown => bail!("cannot update last run time for unknown job state"), > + JobState::Unknown => JobState::Created { time }, > }; > job.write_state() > }