From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4DF938A524 for <pbs-devel@lists.proxmox.com>; Thu, 20 Oct 2022 09:41:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 30AAF410B for <pbs-devel@lists.proxmox.com>; Thu, 20 Oct 2022 09:41:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pbs-devel@lists.proxmox.com>; Thu, 20 Oct 2022 09:40:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 856EB44AA7 for <pbs-devel@lists.proxmox.com>; Thu, 20 Oct 2022 09:40:59 +0200 (CEST) From: Dominik Csapak <d.csapak@proxmox.com> To: pbs-devel@lists.proxmox.com Date: Thu, 20 Oct 2022 09:40:53 +0200 Message-Id: <20221020074058.717152-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.068 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup v3 0/5] add 'sync-level' to datatore tuning options X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 20 Oct 2022 07:41:01 -0000 adds a sync-level option to the datastore tuning option, so that the user can decide which level of file consitency is wanted, and afterwards set the default to 'filesystem' changes from v2: * rebase on master * fix typos in documentation changes from v1: * rebase on master * reword documentation to be slightly less opinionated about which option is better changes from RFC: * seperate introducing of the option and changing the default * renaming to DatastoreFSyncLevel * adding more and better comments + docs * saving the whole level and not only a bool in the datastore/chunk_store * adding a fsync on the dir handle for the 'file' case in insert_chunk * split the change to 'replace_file' into seperate patch the first patch is mostly unrelated, but it introduces a place where we can document the option, and could be applied independent from the remaining patches of this series. the second patch only changes the use of replace_file in insert_chunk, so that could also be applied independently. Dominik Csapak (5): docs: add information about chunk order option for datastores pbs-datastore: chunk_store: use replace_file in insert_chunk datastore: implement sync-level tuning for datastores docs: add documentation about the 'sync-level' tuning datastore: make 'filesystem' the default sync-level docs/storage.rst | 59 ++++++++++++++++++++++++++++ pbs-api-types/src/datastore.rs | 37 ++++++++++++++++++ pbs-datastore/src/chunk_store.rs | 66 +++++++++++++++++++++++--------- pbs-datastore/src/datastore.rs | 39 +++++++++++++++++-- src/api2/backup/environment.rs | 2 + src/api2/config/datastore.rs | 9 ++++- 6 files changed, 187 insertions(+), 25 deletions(-) -- 2.30.2