From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 8C03292275
for <pve-devel@lists.proxmox.com>; Mon, 12 Sep 2022 11:24:34 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 7A37F2CE5
for <pve-devel@lists.proxmox.com>; Mon, 12 Sep 2022 11:24:04 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Mon, 12 Sep 2022 11:24:03 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BC8B0433D8
for <pve-devel@lists.proxmox.com>; Mon, 12 Sep 2022 11:24:03 +0200 (CEST)
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Mon, 12 Sep 2022 11:24:03 +0200
Message-Id: <20220912092403.1608055-1-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.092 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: [pve-devel] [PATCH pve-flutter-frontend] fix text selection theme
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 12 Sep 2022 09:24:34 -0000
by default, flutter derives the text selection theme from the global
MaterialApp defined themes primary color, which is problematic in our
case, since we often have the same primary color as background for text
fields. This resulted in the cursorColor/selectionHandleColor to be the
same as the background, making them invisible.
Fix it by creating a manual textSelectionTheme with colors that properly
contrast the background. (The color works well for both light and dark mode)
The selectionHandleColor is modifed with an opacity of 0.4 like flutter
does by default.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
lib/main.dart | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/lib/main.dart b/lib/main.dart
index d3709f9..0245552 100644
--- a/lib/main.dart
+++ b/lib/main.dart
@@ -134,6 +134,11 @@ class MyApp extends StatelessWidget {
backgroundColor: ProxmoxColors.supportBlue, // primary
foregroundColor: Colors.white, // onPrimary
),
+ textSelectionTheme: TextSelectionThemeData(
+ selectionColor: ProxmoxColors.orange.withOpacity(0.4),
+ selectionHandleColor: ProxmoxColors.orange,
+ cursorColor: ProxmoxColors.orange,
+ ),
),
darkTheme: ThemeData(
colorScheme: ColorScheme.dark(
@@ -170,6 +175,11 @@ class MyApp extends StatelessWidget {
TextStyle(fontFamily: "Open Sans", fontWeight: FontWeight.w700),
),
scaffoldBackgroundColor: ProxmoxColors.grey,
+ textSelectionTheme: TextSelectionThemeData(
+ selectionColor: ProxmoxColors.orange.withOpacity(0.4),
+ selectionHandleColor: ProxmoxColors.orange,
+ cursorColor: ProxmoxColors.orange,
+ ),
),
builder: (context, child) {
return StreamListener(
--
2.30.2