From: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage v4 3/4] Switched to using log_warn of PVE::RESTEnvironment
Date: Tue, 14 Jun 2022 11:00:12 +0200 [thread overview]
Message-ID: <20220614090013.84500-3-d.tschlatscher@proxmox.com> (raw)
In-Reply-To: <20220614090013.84500-1-d.tschlatscher@proxmox.com>
Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
---
Changes from v3
* No fix #xxxx in commit title
* Added import for PVE::RESTEnvironment to call log_warn directly
PVE/Storage.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/Storage.pm b/PVE/Storage.pm
index 97ea64e..0d53ba2 100755
--- a/PVE/Storage.pm
+++ b/PVE/Storage.pm
@@ -23,6 +23,7 @@ use PVE::JSONSchema;
use PVE::INotify;
use PVE::RPCEnvironment;
use PVE::SSHInfo;
+use PVE::RESTEnvironment qw(log_warn);
use PVE::Storage::Plugin;
use PVE::Storage::DirPlugin;
@@ -1602,7 +1603,7 @@ sub archive_auxiliaries_remove {
my $path = "$dirname/$filename";
if (-e $path) {
- unlink $path or $! == ENOENT or warn "Removing $type file failed: $!\n";
+ unlink $path or $! == ENOENT or log_warn("Removing $type file failed: $!");
}
}
}
--
2.30.2
next prev parent reply other threads:[~2022-06-14 9:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 9:00 [pve-devel] [PATCH storage v4 1/4] fix #3972: Remove the .notes file when a backup is deleted Daniel Tschlatscher
2022-06-14 9:00 ` [pve-devel] [PATCH storage v4 2/4] Adapted unlink calls for archive files in case of ENOENT Daniel Tschlatscher
2022-06-14 9:00 ` Daniel Tschlatscher [this message]
2022-06-14 9:00 ` [pve-devel] [PATCH storage v4 4/4] Added a LOG_EXT constant as a counterpart to NOTES_EXT Daniel Tschlatscher
2022-06-15 8:52 ` [pve-devel] applied series: [PATCH storage v4 1/4] fix #3972: Remove the .notes file when a backup is deleted Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614090013.84500-3-d.tschlatscher@proxmox.com \
--to=d.tschlatscher@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal