From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox/backup/common/storage/wt] add tar.zst download in pve
Date: Tue, 31 May 2022 13:17:19 +0200 [thread overview]
Message-ID: <20220531111726.2972022-1-d.csapak@proxmox.com> (raw)
like we have the tar.zst download button for pbs itself, add it for
pve for both vms and container file-restore
pve-storage depends on pve-common, which depends on proxmox-backup,
which depends on proxmox
(we must bump proxmox-compression and add the new version as a
dependency; also for the restore-daemon)
widget-toolkit could be done differently (just set enableTar to true;
either by default or in proxmox-backup), but since we don't use
it anywhere else, this seemed wrong
also i am not completely happy with the interface: i added a 'tar' parameter
to the download path (for gui compatibility) and to the file-restore
binary, but moved to a 'format' parameter in the restore-daemon.
i'd really prefer to have a single parameter style for that, but i did not want
to pass through the 'tar' through all layers, and moving all to a 'format'
parameter would be more work (api compatibility etc.). so maybe someone else has
another take on, which way i should pursue in a v2?
also AFAICS, the restore-daemon and file-restore binary always go
together, so do we have to keep the api of the restore-daemon
compatible ? (theoretically users could invoke that manually?)
proxmox:
Dominik Csapak (2):
proxmox-compression: make ZstdEncoder stream a bit more generic
proxmox-compression: add 'tar_directory'
proxmox-compression/Cargo.toml | 1 +
proxmox-compression/src/tar.rs | 116 ++++++++++++++++++++++++++++++++
proxmox-compression/src/zstd.rs | 15 +++--
3 files changed, 127 insertions(+), 5 deletions(-)
proxmox-backup:
Dominik Csapak (2):
restore-daemon: add 'format' parameter to the 'extract' handler
file-restore: add 'tar' option to 'extract' command
proxmox-file-restore/Cargo.toml | 1 +
proxmox-file-restore/src/block_driver.rs | 6 +--
proxmox-file-restore/src/block_driver_qemu.rs | 4 +-
proxmox-file-restore/src/main.rs | 51 ++++++++++++++-----
.../src/proxmox_restore_daemon/api.rs | 49 +++++++++++++++---
5 files changed, 88 insertions(+), 23 deletions(-)
pve-common:
Dominik Csapak (1):
PBSClient: add 'tar' parameter to file_restore_extract
src/PVE/PBSClient.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
pve-storage:
Dominik Csapak (1):
api/filerestore: add 'tar' parameter to 'download' api
PVE/API2/Storage/FileRestore.pm | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
proxmox-widget-toolkit:
Dominik Csapak (1):
window/FileBrowser: enable tar button by default
src/window/FileBrowser.js | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
--
2.30.2
WARNING: multiple messages have this Message-ID
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox/backup/common/storage/wt] add tar.zst download in pve
Date: Tue, 31 May 2022 13:17:19 +0200 [thread overview]
Message-ID: <20220531111726.2972022-1-d.csapak@proxmox.com> (raw)
like we have the tar.zst download button for pbs itself, add it for
pve for both vms and container file-restore
pve-storage depends on pve-common, which depends on proxmox-backup,
which depends on proxmox
(we must bump proxmox-compression and add the new version as a
dependency; also for the restore-daemon)
widget-toolkit could be done differently (just set enableTar to true;
either by default or in proxmox-backup), but since we don't use
it anywhere else, this seemed wrong
also i am not completely happy with the interface: i added a 'tar' parameter
to the download path (for gui compatibility) and to the file-restore
binary, but moved to a 'format' parameter in the restore-daemon.
i'd really prefer to have a single parameter style for that, but i did not want
to pass through the 'tar' through all layers, and moving all to a 'format'
parameter would be more work (api compatibility etc.). so maybe someone else has
another take on, which way i should pursue in a v2?
also AFAICS, the restore-daemon and file-restore binary always go
together, so do we have to keep the api of the restore-daemon
compatible ? (theoretically users could invoke that manually?)
proxmox:
Dominik Csapak (2):
proxmox-compression: make ZstdEncoder stream a bit more generic
proxmox-compression: add 'tar_directory'
proxmox-compression/Cargo.toml | 1 +
proxmox-compression/src/tar.rs | 116 ++++++++++++++++++++++++++++++++
proxmox-compression/src/zstd.rs | 15 +++--
3 files changed, 127 insertions(+), 5 deletions(-)
proxmox-backup:
Dominik Csapak (2):
restore-daemon: add 'format' parameter to the 'extract' handler
file-restore: add 'tar' option to 'extract' command
proxmox-file-restore/Cargo.toml | 1 +
proxmox-file-restore/src/block_driver.rs | 6 +--
proxmox-file-restore/src/block_driver_qemu.rs | 4 +-
proxmox-file-restore/src/main.rs | 51 ++++++++++++++-----
.../src/proxmox_restore_daemon/api.rs | 49 +++++++++++++++---
5 files changed, 88 insertions(+), 23 deletions(-)
pve-common:
Dominik Csapak (1):
PBSClient: add 'tar' parameter to file_restore_extract
src/PVE/PBSClient.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
pve-storage:
Dominik Csapak (1):
api/filerestore: add 'tar' parameter to 'download' api
PVE/API2/Storage/FileRestore.pm | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
proxmox-widget-toolkit:
Dominik Csapak (1):
window/FileBrowser: enable tar button by default
src/window/FileBrowser.js | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
--
2.30.2
next reply other threads:[~2022-05-31 11:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 11:17 Dominik Csapak [this message]
2022-05-31 11:17 ` [pbs-devel] " Dominik Csapak
2022-05-31 11:17 ` [pve-devel] [PATCH proxmox 1/2] proxmox-compression: make ZstdEncoder stream a bit more generic Dominik Csapak
2022-05-31 11:17 ` [pbs-devel] " Dominik Csapak
2022-07-05 11:47 ` [pve-devel] applied-both: " Wolfgang Bumiller
2022-07-05 11:47 ` [pbs-devel] " Wolfgang Bumiller
2022-05-31 11:17 ` [pve-devel] [PATCH proxmox 2/2] proxmox-compression: add 'tar_directory' Dominik Csapak
2022-05-31 11:17 ` [pbs-devel] " Dominik Csapak
2022-05-31 11:17 ` [pve-devel] [PATCH proxmox-backup 1/2] restore-daemon: add 'format' parameter to the 'extract' handler Dominik Csapak
2022-05-31 11:17 ` [pbs-devel] " Dominik Csapak
2022-07-05 11:39 ` [pve-devel] " Wolfgang Bumiller
2022-07-05 11:39 ` Wolfgang Bumiller
2022-05-31 11:17 ` [pve-devel] [PATCH proxmox-backup 2/2] file-restore: add 'tar' option to 'extract' command Dominik Csapak
2022-05-31 11:17 ` [pbs-devel] " Dominik Csapak
2022-07-05 11:43 ` [pve-devel] " Wolfgang Bumiller
2022-07-05 11:43 ` Wolfgang Bumiller
2022-05-31 11:17 ` [pve-devel] [PATCH common 1/1] PBSClient: add 'tar' parameter to file_restore_extract Dominik Csapak
2022-05-31 11:17 ` [pbs-devel] " Dominik Csapak
2022-05-31 11:17 ` [pve-devel] [PATCH storage 1/1] api/filerestore: add 'tar' parameter to 'download' api Dominik Csapak
2022-05-31 11:17 ` [pbs-devel] " Dominik Csapak
2022-05-31 11:17 ` [pve-devel] [PATCH widget-toolkit 1/1] window/FileBrowser: enable tar button by default Dominik Csapak
2022-05-31 11:17 ` [pbs-devel] " Dominik Csapak
2022-07-01 12:12 ` [pve-devel] [PATCH proxmox/backup/common/storage/wt] add tar.zst download in pve Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220531111726.2972022-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal