From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 600EE70F08
for <pbs-devel@lists.proxmox.com>; Tue, 17 May 2022 08:52:48 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 56B5A2483B
for <pbs-devel@lists.proxmox.com>; Tue, 17 May 2022 08:52:18 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id AB2A224813
for <pbs-devel@lists.proxmox.com>; Tue, 17 May 2022 08:52:16 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7A4D94366E
for <pbs-devel@lists.proxmox.com>; Tue, 17 May 2022 08:52:16 +0200 (CEST)
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Date: Tue, 17 May 2022 08:52:12 +0200
Message-Id: <20220517065215.327699-2-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220517065215.327699-1-d.csapak@proxmox.com>
References: <20220517065215.327699-1-d.csapak@proxmox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.068 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
POISEN_SPAM_PILL_4 0.1 random spam to be learned in bayes
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [me.store]
Subject: [pbs-devel] [PATCH proxmox-backup 2/5] ui: form/NamespaceSelector:
show proper emptyText
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 17 May 2022 06:52:48 -0000
by filtering out the empty namespace from the api, and putting the
correct div with xclass around the gettext
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/form/NamespaceSelector.js | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/www/form/NamespaceSelector.js b/www/form/NamespaceSelector.js
index 44b7ca0d..c847cd4e 100644
--- a/www/form/NamespaceSelector.js
+++ b/www/form/NamespaceSelector.js
@@ -34,8 +34,8 @@ Ext.define('PBS.form.NamespaceSelector', {
minWidth: 170,
maxWidth: 500,
// below doesn't work :/
- //minHeight: 30,
- //emptyText: gettext('No namespaces accesible.'),
+ minHeight: 30,
+ emptyText: `<div class="x-grid-empty">${gettext('No namespaces accessible.')}</div>`,
},
triggers: {
@@ -82,6 +82,7 @@ Ext.define('PBS.form.NamespaceSelector', {
me.store = Ext.create('Ext.data.Store', {
model: 'pbs-namespaces',
autoLoad: !!me.datastore,
+ filters: (rec) => rec.data.ns !== '',
proxy: {
type: 'proxmox',
timeout: 30 * 1000,
--
2.30.2