From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <f.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id C425EE179
 for <pve-devel@lists.proxmox.com>; Thu, 21 Apr 2022 13:27:38 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id BA4021E29E
 for <pve-devel@lists.proxmox.com>; Thu, 21 Apr 2022 13:27:08 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 1102F1E216
 for <pve-devel@lists.proxmox.com>; Thu, 21 Apr 2022 13:27:06 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D851C426A3
 for <pve-devel@lists.proxmox.com>; Thu, 21 Apr 2022 13:27:05 +0200 (CEST)
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Thu, 21 Apr 2022 13:26:46 +0200
Message-Id: <20220421112659.74011-1-f.ebner@proxmox.com>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.089 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: [pve-devel] [PATCH-SERIES v2
 qemu/qemu-server/widget-toolkit/manager] more flexible restore
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 21 Apr 2022 11:27:39 -0000

Allows preserving disks and overriding VM settings upon restore.
For containers, overriding settings was already possible, but managing
partial restore is more involved because of nested mount structure,
etc.

Exposes the functionality in the UI, allowing to set (host)name,
cores(+sockets), memory, and, for VMs, whether disks should be
preserved.

Also includes related improvements, like cleaning up snapshots on
drives and cloundinit correctly and, in the UI, detecting if a storage
needed by the restore is not available.


Changes from v1:
    * Use skip=<drivename> to communicate skipping restore to VMA
      rather than treating path /dev/null in a special way.
    * Use explicit preserve-drives parameter for VM create API to
      avoid automagic and conflict with existing syntax for LXC.
    * Add UI patches.


Necessary dependency bumps are pve-manager -> widget-toolkit
and pve-manager -> qemu-server -> qemu.


Still missing: add documentation for the new restore functionality
for VMs and existing restore functionality for containers.


qemu:

Fabian Ebner (2):
  vma: restore: call blk_unref for all opened block devices
  vma: allow partial restore

 vma-reader.c |  67 ++++++++++++---------
 vma.c        | 163 ++++++++++++++++++++++++++++-----------------------
 vma.h        |   2 +-
 3 files changed, 131 insertions(+), 101 deletions(-)


qemu-server:

Fabian Ebner (7):
  restore: cleanup oldconf: also clean up snapshots from kept volumes
  restore destroy volumes: remove check for absolute path
  restore deactivate volumes: never die
  restore: also deactivate/destroy cloud-init disk upon error
  api: create: refactor parameter check logic
  api: create: allow overriding non-disk options during restore
  restore: allow preserving drives during restore

 PVE/API2/Qemu.pm  |  63 +++++++++++++++++++-------
 PVE/QemuServer.pm | 112 +++++++++++++++++++++++++++++++++-------------
 2 files changed, 126 insertions(+), 49 deletions(-)


widget-toolkit:

Fabian Ebner (1):
  css: add proxmox-good-row class

 src/css/ext6-pmx.css | 4 ++++
 1 file changed, 4 insertions(+)


manager:

Fabian Ebner (3):
  ui: restore: disallow empty storage selection if it wouldn't work
  ui: restore: allow override of some settings
  ui: restore: allow preserving disks

 www/manager6/Makefile                |   1 +
 www/manager6/grid/RestoreDiskGrid.js | 125 +++++++++++++++++++++++
 www/manager6/window/Restore.js       | 146 ++++++++++++++++++++++++++-
 3 files changed, 269 insertions(+), 3 deletions(-)
 create mode 100644 www/manager6/grid/RestoreDiskGrid.js

-- 
2.30.2