From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <a.lauterer@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id BB4C46DE6F
 for <pve-devel@lists.proxmox.com>; Mon, 28 Mar 2022 13:10:43 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id B98F524F5D
 for <pve-devel@lists.proxmox.com>; Mon, 28 Mar 2022 13:10:43 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 3C64024F53
 for <pve-devel@lists.proxmox.com>; Mon, 28 Mar 2022 13:10:43 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 12D6B428F2
 for <pve-devel@lists.proxmox.com>; Mon, 28 Mar 2022 13:10:43 +0200 (CEST)
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Mon, 28 Mar 2022 13:10:41 +0200
Message-Id: <20220328111041.1732567-2-a.lauterer@proxmox.com>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20220328111041.1732567-1-a.lauterer@proxmox.com>
References: <20220328111041.1732567-1-a.lauterer@proxmox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.029 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
Subject: [pve-devel] [PATCH manager 2/2] ui: osd: remove NA from wal device
 column
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 28 Mar 2022 11:10:43 -0000

It adds visual noise and reduces readability.
This brings the WAL device column in alignment with the DB device column
which is showing whitespace if there is none configured.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
 www/manager6/ceph/OSD.js | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js
index 78f226ff..adc35464 100644
--- a/www/manager6/ceph/OSD.js
+++ b/www/manager6/ceph/OSD.js
@@ -516,15 +516,6 @@ Ext.define('PVE.node.CephOsdTree', {
 	    return text;
 	},
 
-	render_wal: function(value, metaData, rec) {
-	    if (!value &&
-		rec.data.osdtype === 'bluestore' &&
-		rec.data.type === 'osd') {
-		return 'N/A';
-	    }
-	    return value;
-	},
-
 	render_version: function(value, metadata, rec) {
 	    let vm = this.getViewModel();
 	    let versions = vm.get('versions');
@@ -638,7 +629,6 @@ Ext.define('PVE.node.CephOsdTree', {
 	    text: "WAL Device",
 	    dataIndex: 'waldev',
 	    align: 'right',
-	    renderer: 'render_wal',
 	    width: 75,
 	    hidden: true,
 	},
-- 
2.30.2