From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id C99E465DB2
for <pve-devel@lists.proxmox.com>; Wed, 9 Mar 2022 09:26:54 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id BCDE71A52B
for <pve-devel@lists.proxmox.com>; Wed, 9 Mar 2022 09:26:54 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 3AB901A522
for <pve-devel@lists.proxmox.com>; Wed, 9 Mar 2022 09:26:54 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0E7C44183C
for <pve-devel@lists.proxmox.com>; Wed, 9 Mar 2022 09:26:54 +0100 (CET)
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Wed, 9 Mar 2022 09:26:53 +0100
Message-Id: <20220309082653.834032-1-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.153 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: [pve-devel] [PATCH novnc] don't require confirmation for starting a
stopped vm from button
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 09 Mar 2022 08:26:54 -0000
when the vm is stopped and the user clicks on the 'start now' button,
there really is no need for confirmation again
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
...ow-start-button-on-not-running-vm-ct.patch | 26 ++++++++++++++++---
1 file changed, 22 insertions(+), 4 deletions(-)
diff --git a/debian/patches/0018-show-start-button-on-not-running-vm-ct.patch b/debian/patches/0018-show-start-button-on-not-running-vm-ct.patch
index 1e9e73d..162acc4 100644
--- a/debian/patches/0018-show-start-button-on-not-running-vm-ct.patch
+++ b/debian/patches/0018-show-start-button-on-not-running-vm-ct.patch
@@ -13,22 +13,40 @@ colors were adapted
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
- app/pve.js | 34 +++++++++++++++++++++++++--
+ app/pve.js | 38 ++++++++++++++++++++++++++----
app/styles/pve.css | 58 ++++++++++++++++++++++++++++++++++++++++++++++
vnc.html | 9 +++++++
- 3 files changed, 99 insertions(+), 2 deletions(-)
+ 3 files changed, 101 insertions(+), 4 deletions(-)
diff --git a/app/pve.js b/app/pve.js
-index 583a406..8144fdb 100644
+index 583a406..3eeaa47 100644
--- a/app/pve.js
+++ b/app/pve.js
+@@ -231,7 +231,7 @@ PVEUI.prototype = {
+
+ },
+
+- pve_vm_command: function(cmd, params, reload) {
++ pve_vm_command: function(cmd, params, reload, mustConfirm = true) {
+ var me = this;
+ var baseUrl;
+ var confirmMsg = "";
+@@ -255,7 +255,7 @@ PVEUI.prototype = {
+
+ confirmMsg = confirmMsg.replace('{0}', me.vmid);
+
+- if (confirmMsg !== "" && confirm(confirmMsg) !== true) {
++ if (confirmMsg !== "" && mustConfirm && confirm(confirmMsg) !== true) {
+ return;
+ }
+
@@ -320,6 +320,11 @@ PVEUI.prototype = {
.classList.add('pve_hidden');
}
+ document.getElementById("pve_start_button")
+ .addEventListener('click', function() {
-+ me.pve_vm_command('start');
++ me.pve_vm_command('start', {}, undefined, false);
+ });
+
// add command logic
--
2.30.2