all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 2/3] ui: traffic-control: fix sending network value
Date: Mon, 22 Nov 2021 09:09:34 +0100	[thread overview]
Message-ID: <20211122080935.577807-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20211122080935.577807-1-d.csapak@proxmox.com>

we forgot to correclty send the network value as we changed from
the radiogroup to a simple text field

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/window/TrafficControlEdit.js | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/www/window/TrafficControlEdit.js b/www/window/TrafficControlEdit.js
index 53b15427..69b01f7d 100644
--- a/www/window/TrafficControlEdit.js
+++ b/www/window/TrafficControlEdit.js
@@ -194,9 +194,9 @@ Ext.define('PBS.window.TrafficControlEdit', {
 	    let me = this;
 	    let isCreate = me.up('window').isCreate;
 
-	    if (!values['network-select']) {
+	    if (!values.network) {
 		values.network = '0.0.0.0/0';
-	    } else if (values.network) {
+	    } else {
 		values.network = values.network.split(/\s*,\s*/);
 	    }
 
@@ -442,10 +442,7 @@ Ext.define('PBS.window.TrafficControlEdit', {
 		success: function(response) {
 		    let data = response.result.data;
 		    if (data.network?.length === 1 && data.network[0] === '0.0.0.0/0') {
-			data['network-select'] = 'all';
 			delete data.network;
-		    } else {
-			data['network-select'] = 'limit';
 		    }
 
 		    if (Ext.isArray(data.timeframe)) {
-- 
2.30.2





  reply	other threads:[~2021-11-22  8:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-22  8:09 [pbs-devel] [PATCH proxmox-backup 1/3] ui: indentation fix Dominik Csapak
2021-11-22  8:09 ` Dominik Csapak [this message]
2021-11-22  8:09 ` [pbs-devel] [PATCH proxmox-backup 3/3] ui: traffic-control: include ipv6 in 'all' networks Dominik Csapak
2021-11-22  9:49 ` [pbs-devel] applied: [PATCH proxmox-backup 1/3] ui: indentation fix Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211122080935.577807-2-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal