From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id CF4997BA50
for <pbs-devel@lists.proxmox.com>; Tue, 2 Nov 2021 10:39:09 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id BFAD52D48E
for <pbs-devel@lists.proxmox.com>; Tue, 2 Nov 2021 10:39:09 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 4757E2D485
for <pbs-devel@lists.proxmox.com>; Tue, 2 Nov 2021 10:39:09 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1830445A82
for <pbs-devel@lists.proxmox.com>; Tue, 2 Nov 2021 10:39:09 +0100 (CET)
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Date: Tue, 2 Nov 2021 10:39:08 +0100
Message-Id: <20211102093908.1632177-1-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.256 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pbs-devel] [PATCH proxmox-backup] api: zfs: create zpool with
atime=off and relatime=on
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 02 Nov 2021 09:39:09 -0000
some operations (e.g. garbage collection/restore/etc.) are very read
intensive on the chunks, and having atime=on (zfs default) makes those
write intensive operations too. Additionally, 'ext4' defaults to relatime,
so also change the default for api-created zpools.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/api2/node/disks/zfs.rs | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/src/api2/node/disks/zfs.rs b/src/api2/node/disks/zfs.rs
index 9c3a0958..242f5f7b 100644
--- a/src/api2/node/disks/zfs.rs
+++ b/src/api2/node/disks/zfs.rs
@@ -273,13 +273,15 @@ pub fn create_zpool(
proxmox_systemd::enable_unit(&import_unit)?;
}
+ let mut command = std::process::Command::new("zfs");
+ command.arg("set");
if let Some(compression) = compression {
- let mut command = std::process::Command::new("zfs");
- command.args(&["set", &format!("compression={}", compression), &name]);
- task_log!(worker, "# {:?}", command);
- let output = pbs_tools::run_command(command, None)?;
- task_log!(worker, "{}", output);
+ command.arg(&format!("compression={}", compression));
}
+ command.args(&["atime=off", "relatime=on", &name]);
+ task_log!(worker, "# {:?}", command);
+ let output = pbs_tools::run_command(command, None)?;
+ task_log!(worker, "{}", output);
if add_datastore {
let lock = pbs_config::datastore::lock_config()?;
--
2.30.2